Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUGGESTION] Not having any edit mode tests and using testMode: all will cause a timeout and the action will fail #248

Open
Zh4rsiest opened this issue Nov 29, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Zh4rsiest
Copy link

Bug description

This might not be a bug at all because you could assume that one has edit mode tests as well when running unity-test-runner with testMode: all option, but the error message was not easy for a beginner to understand. The error message was the following after # Testing in COMBINE_RESULTS #:

Aborting batchmode due to failure:
Timeout after 300 seconds while waiting async operations to finish. executeMethod ''

Although I don't have enough knowledge about unity-actions I think it should be mentioned either in the documentation for the testMode parameter, or in https://game.ci/docs/troubleshooting/common-issues

How to reproduce

  • Don't have any edit mode tests
  • Set unity-test-runner's testMode parameter to all or leave it empty as the default value is all
  • the unity-test-runner job will fail

Expected behavior

Not sure if this should be it, but the job shouldn't perform any edit mode tests if there aren't any

Additional details

This is merely a suggestion as like I stated before, I'm not knowledgeable enough on how this works 😬

@Zh4rsiest Zh4rsiest added the bug Something isn't working label Nov 29, 2022
@webbertakken webbertakken added enhancement New feature or request and removed bug Something isn't working labels Nov 29, 2022
@webbertakken
Copy link
Member

Thank you for your suggestion.

Marking this as an enhancement, as that is the behaviour from the unity editor, but we can probably work around it somehow.

@AndrewKahr AndrewKahr transferred this issue from game-ci/unity-actions Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants