GTE.STORAGE.settingsOrientation breaks firefox

[stengel]

The following bug is present but not apparent when the page is first loaded. The behavior will be hard to reproduce (and would be interesting to explain). It is clearly related to the fact that currently (in Firefox or chrome), displaying in horizontal mode does not work, the tree stays vertical.

The described behavior is all in Firefox (which I first thought was a caching problem).

Consider the attached screenshot which shows, for the SAME FILE path, that jsgte is broken in the top figure: The players are not shown, no tree is shown, and in fact "hover" is all that works when you use the mouse, no reaction to clicking.

THIS DOES NOT APPEAR IN A PRIVATE WINDOW, nor if you rename the directory path.

In the broken (top) scenario, CTRL-SHIFT-I shows the debugging information

TypeError: document.getElementById(...).getElementsByTagName(...)[GTE.STORAGE.settingsOrientation] is undefined

and main.js line 42 says:

document.getElementById("orientation").getElementsByTagName("input")[GTE.STORAGE.settingsOrientation].checked = true;

So I commented out line 42 in main.js and I got the tree but the settings panel behaved a bit weirdly. When I undid this uncommenting and reloaded, the page BEHAVED OK, as in the new private window.

Clearly, firefox had somehow kept GTE.STORAGE for this page and produced the type error.

We should check for GTE.STORAGE.settingsOrientation and see why it is dysfunctional.

[stengel]

Also, firefox REMEMBERS the settings (such as circle diameter) from one session to the next.
We should understand how.

[hkirat]

Using local storage
https://developer.mozilla.org/en/docs/Web/API/Window/localStorage
Try firing the console in mozilla and typing "localStorage".
There might be an illegal value in some of the storage variables that made it break.