Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Color Inversion property for Chance Player icon #61

Open
PARAG00991 opened this issue Mar 13, 2016 · 1 comment
Open

Implementing Color Inversion property for Chance Player icon #61

PARAG00991 opened this issue Mar 13, 2016 · 1 comment

Comments

@PARAG00991
Copy link

The Chance Player icon on toolbar doesn't show any color inversion when mouse pointer is moved over it like the other icons on the toolbar except the player icons. The icon actually doesn't look distinguishable with its background color on hover or when the icon is selected. I can implement this but first I'd like to get it approved that whether it is required or not.
@stengel , what are you thoughts on this?

@kagolaub
Copy link

Ah, I think I solved this little design issue a while ago. I'll push it and make a pull request to just showcase this option; the error resided in the button's inline css in Tools.js overriding the inheritance of color from the button-sacnite hover class. To fix this, I chose to add another layer of specificity for the button style definition.

@kagolaub kagolaub mentioned this issue Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants