-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design of the Instrument class #10
Comments
Possibly each channel is a dictionary with predefined keys, otherwise implement a Class
People can subclass for example to reimplement |
need to specify a |
I believe it is a good idea, as it is now, to have the
Model
subclasses take care of the bandpass integration, see #9However, I think it is convenient to have a
Instrument
class with a similar interface to PySM 2, it is a good way of grouping the instrument properties together that are otherwise just independent arrays likefwhms
andbandpasses
.We can still provide the same
observe
method that callsget_integrated_emission
ofSky
and passes bandpasses.Smoothing instead can just be implemented inside
Instrument
, I don't think there is any advantage in implementing it insideModel
.Finally
Instrument
will be able to generate white noise maps and also optionally write the outputs to disk. So it should process one channel at a time.The text was updated successfully, but these errors were encountered: