Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail test if tool writes to input dir #1189

Closed
bernt-matthias opened this issue Sep 24, 2021 · 2 comments · May be fixed by #1190
Closed

Fail test if tool writes to input dir #1189

bernt-matthias opened this issue Sep 24, 2021 · 2 comments · May be fixed by #1190

Comments

@bernt-matthias
Copy link
Contributor

Would be nice if planemo test would fail for such cases automatically. Like so galaxyproject/tools-iuc#3986 (comment)
@bernt-matthias
Copy link
Contributor Author

Alternatively we could do the following in the CI:

FILE_PATH=$(mktemp -d)
planemo test --file_path $FILEPATH ...

WROTE=$(find $FILE_PATH -type f \( ! -name "*.dat" ! -name "dataset_.*_files" \))

if [[ $WROTE ]]; then
    >&2 echo "tool wrote files into Galaxy's file dir: "
    >&2 echo $WROTE
    exit 1
fi

This was referenced Sep 24, 2021
Merged
Open
@bernt-matthias
Copy link
Contributor Author

Closing this, since containerized testing allows to do this. Still I leave #1190 open, because it might have value .. but others need to judge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: check if extra files were created in Galaxy's file_path bernt-matthias/planemo
1 participant
@bernt-matthias