Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linting of TS-invalid repository name should raise error #1112

Open
martenson opened this issue Dec 14, 2020 · 2 comments · May be fixed by #1111
Open

linting of TS-invalid repository name should raise error #1112

martenson opened this issue Dec 14, 2020 · 2 comments · May be fixed by #1111
Assignees
@bernt-matthias

Comments

@martenson
Copy link
Member

We just had a case (repo name apCLMS_to_RamClustR_converter) where the CI passes fine but the toolshed upload fails (silently)

Unexpected HTTP status code: 400: {"err_msg": "Repository names must contain only lower-case letters, numbers and underscore.", "err_code": 400008}
@bernt-matthias
Copy link
Contributor

I think this should be part of planemo lint or shed_lint.

@bernt-matthias bernt-matthias self-assigned this Dec 15, 2020
@bernt-matthias
Copy link
Contributor

shed_lint reports

.. WARNING: Repository name [apCLMS_to_RamClustR_converter] invalid. Repository names must contain only lower-case letters, numbers and underscore.

Since we call shed_lint with --report_level warn --fail_level error this "error" is missed.

I guess we should change this to error since using --fail_level warn would catch to many cases.

In addition I think it would be nice to make users more aware of these warnings.

bernt-matthias referenced this issue in bernt-matthias/planemo Dec 15, 2020
@bernt-matthias
raise report level for some shed linting
2f8d4f6 
I think these are all cases which lead to errors in deploying.

fixes https://github.com/galaxyproject/tools-iuc/issues/3384
bernt-matthias referenced this issue in bernt-matthias/planemo Dec 15, 2020
@bernt-matthias
raise report level for some shed linting
02a2411 
I think these are all cases which lead to errors in deploying.

fixes https://github.com/galaxyproject/tools-iuc/issues/3384
@nsoranzo nsoranzo transferred this issue from galaxyproject/tools-iuc Dec 15, 2020
@nsoranzo nsoranzo linked a pull request Dec 15, 2020 that will close this issue
Open
@martenson martenson changed the title Make CI check for validity of repository name linting of TS-invalid repository name should raise error Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bernt-matthias bernt-matthias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

raise report level for some shed linting bernt-matthias/planemo
2 participants
@martenson @bernt-matthias