Sharing role title does not include "USER PURGED" string instead of purged user's email

[jdavcs]

A sharing role title includes the email of each user it is shared with. Once a user is purged, that email should be replaced with USER PURGED. It is not; instead it is replaced with the hash that replaced the user's email on purge.

Introduced: #19096

EDIT: must also look into unit test that was supposed to cover this.

[martenson]

I thought that's covered here

galaxy/test/unit/data/model/db/test_user.py

Line 129 in 6fa4fbb

assert role_sharing1.name == "sharing role for [USER PURGED], [email protected]"

[jdavcs]

I thought that's covered here

galaxy/test/unit/data/model/db/test_user.py

Line 129 in 6fa4fbb

assert role_sharing1.name == "sharing role for [USER PURGED], [email protected]"

I thought so too! Apparently not.

[jdavcs]

It is not a sharing role title: it is just a private role of a purged user, so it's displayed as expected. These hashes are displayed everywhere where a purged user's private role was associated with an item. It's not ideal, we probably should replace these long strings with a helpful placeholder on the UI ("purged user"?), but it's not a bug.