Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch data tool should throw RequestParameterInvalid for uploads from unverifiable urls #18154

Closed
galaxyproject-sentryintegration bot opened this issue May 15, 2024 · 1 comment

Comments

@galaxyproject-sentryintegration

The user is uploading http://sra12345

Sentry Issue: GALAXY-MAIN-XCZ

ExceptionGroup: unhandled errors in a TaskGroup
  File "starlette/_utils.py", line 87, in collapse_excgroups
    yield
  File "starlette/middleware/base.py", line 190, in __call__
    async with anyio.create_task_group() as task_group:
  File "anyio/_backends/_asyncio.py", line 678, in __aexit__
    raise BaseExceptionGroup(

gaierror: [Errno -2] Name or service not known
(28 additional frame(s) were not displayed)
...
  File "galaxy/webapps/galaxy/services/_fetch_util.py", line 196, in _for_each_src
    _for_each_src(f, value)
  File "galaxy/webapps/galaxy/services/_fetch_util.py", line 191, in _for_each_src
    _for_each_src(f, item)
  File "galaxy/webapps/galaxy/services/_fetch_util.py", line 194, in _for_each_src
    f(obj)
  File "galaxy/webapps/galaxy/services/_fetch_util.py", line 164, in check_src
    validate_non_local(url, trans.app.config.fetch_url_allowlist_ips)
  File "galaxy/files/uris.py", line 128, in validate_non_local
    addrinfo = socket.getaddrinfo(parsed_url, port)
@mvdbeek
Copy link
Member

mvdbeek commented May 20, 2024

Fixed in #18155

@mvdbeek mvdbeek closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant