Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[form parameter] text, password: "_fieldText" #12871

Closed
dannon opened this issue Nov 9, 2021 · 5 comments
Closed

[form parameter] text, password: "_fieldText" #12871

dannon opened this issue Nov 9, 2021 · 5 comments
Assignees
@neoformit

Comments

@dannon
Copy link
Member

dannon commented Nov 9, 2021 •
edited
Loading

This is an issue for tracking/assigning conversion of the backbone form input (found here: https://github.com/galaxyproject/galaxy/blob/dev/client/src/components/Form/Elements/parameters.js) into a vue component.

For more details see #11076
@dannon dannon mentioned this issue Nov 9, 2021
Closed
@dannon dannon assigned dannon and unassigned dannon Jan 14, 2022
@dannon
Copy link
Member Author

dannon commented Jan 18, 2022

@neoformit is going to take a stab at this one (will update assignment when org invite propagates)

@neoformit
Copy link
Collaborator

Thanks @dannon

@neoformit
Copy link
Collaborator

I don't think Ui.Input or Ui.NullableText can be removed from ui-misc.js yet as other components depend on them:

  • parameters.js : _fieldSelect
  • galaxy/client/src/mvc/visualization/chart/views/editor.js

parameters.js will resolve itself when that gets refactored to Vue. I'm guessing we can swap out the dep in editor.js?

@neoformit
Copy link
Collaborator

#13375

@assuntad23
Copy link
Contributor

Closed with #13375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neoformit neoformit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dannon @assuntad23 @neoformit