From f71de4399a10a7cfd9b5f1309fc56e3cc359d258 Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Tue, 9 Apr 2024 17:49:39 +0200 Subject: [PATCH] Revert unnecessary error change Upgrade messages are collected via step.upgrade_messages. Addresses https://github.com/galaxyproject/galaxy/pull/17858/files#r1557810107 --- lib/galaxy/managers/workflows.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/galaxy/managers/workflows.py b/lib/galaxy/managers/workflows.py index 89cc96698b83..114d11301ac8 100644 --- a/lib/galaxy/managers/workflows.py +++ b/lib/galaxy/managers/workflows.py @@ -1461,12 +1461,11 @@ def _workflow_to_dict_export(self, trans, stored=None, workflow=None, internal=F if not annotation_str and annotation_owner: annotation_str = self.get_item_annotation_str(trans.sa_session, annotation_owner, step) or "" content_id = module.get_content_id() if allow_upgrade else step.content_id - errors = {} try: tool_state = module.get_export_state() except ValueError: # Fix state if necessary - errors = module.check_and_update_state() + module.check_and_update_state() tool_state = module.get_export_state() # Step info @@ -1478,7 +1477,7 @@ def _workflow_to_dict_export(self, trans, stored=None, workflow=None, internal=F "tool_version": module.get_version() if allow_upgrade else step.tool_version, "name": module.get_name(), "tool_state": json.dumps(tool_state), - "errors": errors or module.get_errors(), + "errors": module.get_errors(), "uuid": str(step.uuid), "label": step.label or None, "annotation": annotation_str,