From 0ac365e406a56fd3fe1dd4d364fed9f805be18c0 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sat, 11 May 2024 12:23:51 +0300
Subject: [PATCH 01/15] Consolidate workflow run error messages, require
 editing the workflow first

---
 .../components/Workflow/Run/WorkflowRun.vue   | 50 +++++++++----------
 1 file changed, 24 insertions(+), 26 deletions(-)

diff --git a/client/src/components/Workflow/Run/WorkflowRun.vue b/client/src/components/Workflow/Run/WorkflowRun.vue
index 8ab28c028b09..70f82cc704ee 100644
--- a/client/src/components/Workflow/Run/WorkflowRun.vue
+++ b/client/src/components/Workflow/Run/WorkflowRun.vue
@@ -10,35 +10,30 @@
             </b-alert>
             <WorkflowRunSuccess v-else-if="!!invocations" :invocations="invocations" :workflow-name="workflowName" />
             <div v-else class="ui-form-composite">
-                <div class="ui-form-composite-messages mb-4">
-                    <b-alert v-if="hasUpgradeMessages" variant="warning" show>
-                        Some tools in this workflow may have changed since it was last saved or some errors were found.
-                        The workflow may still run, but any new options will have default values. Please review the
-                        messages below to make a decision about whether the changes will affect your analysis.
-                    </b-alert>
-                    <b-alert v-if="hasStepVersionChanges" variant="warning" show>
-                        Some tools are being executed with different versions compared to those available when this
-                        workflow was last saved because the other versions are not or no longer available on this Galaxy
-                        instance. To upgrade your workflow and dismiss this message simply edit the workflow and re-save
-                        it.
-                    </b-alert>
-                    <b-alert v-if="submissionError" variant="danger" show>
+                <b-alert v-if="hasUpgradeMessages || hasStepVersionChanges" class="mb-4" variant="warning" show>
+                    The <b>`{{ model.name }}`</b> workflow may contain tools which have changed since it was last saved
+                    or some error have been detected. Please
+                    <a :to="editorLink" :href="editorLink">click here to edit and review the issues</a> before running
+                    this workflow.
+                </b-alert>
+                <div v-else>
+                    <b-alert v-if="submissionError" class="mb-4" variant="danger" show>
                         Workflow submission failed: {{ submissionError }}
                     </b-alert>
+                    <WorkflowRunFormSimple
+                        v-else-if="simpleForm"
+                        :model="model"
+                        :target-history="simpleFormTargetHistory"
+                        :use-job-cache="simpleFormUseJobCache"
+                        @submissionSuccess="handleInvocations"
+                        @submissionError="handleSubmissionError"
+                        @showAdvanced="showAdvanced" />
+                    <WorkflowRunForm
+                        v-else
+                        :model="model"
+                        @submissionSuccess="handleInvocations"
+                        @submissionError="handleSubmissionError" />
                 </div>
-                <WorkflowRunFormSimple
-                    v-if="simpleForm"
-                    :model="model"
-                    :target-history="simpleFormTargetHistory"
-                    :use-job-cache="simpleFormUseJobCache"
-                    @submissionSuccess="handleInvocations"
-                    @submissionError="handleSubmissionError"
-                    @showAdvanced="showAdvanced" />
-                <WorkflowRunForm
-                    v-else
-                    :model="model"
-                    @submissionSuccess="handleInvocations"
-                    @submissionError="handleSubmissionError" />
             </div>
         </span>
     </span>
@@ -99,6 +94,9 @@ export default {
     computed: {
         ...mapState(useHistoryStore, ["currentHistoryId", "getHistoryById"]),
         ...mapState(useHistoryItemsStore, ["lastUpdateTime"]),
+        editorLink() {
+            return `/workflows/edit?id=${this.model.workflowId}`;
+        },
         historyStatusKey() {
             return `${this.currentHistoryId}_${this.lastUpdateTime}`;
         },

From 8ddb0004ebeeddba85e4e3b5b2385d0f9ed2bdb2 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sat, 11 May 2024 12:33:55 +0300
Subject: [PATCH 02/15] Add owners user id to workflow run form response

---
 lib/galaxy/managers/workflows.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/galaxy/managers/workflows.py b/lib/galaxy/managers/workflows.py
index 563314260d00..b2f17de32871 100644
--- a/lib/galaxy/managers/workflows.py
+++ b/lib/galaxy/managers/workflows.py
@@ -1048,6 +1048,7 @@ def _workflow_to_dict_run(self, trans, stored, workflow, history=None):
             "name": stored.name,
             "steps": step_models,
             "step_version_changes": step_version_changes,
+            "user_id": trans.app.security.encode_id(stored.user_id),
             "has_upgrade_messages": has_upgrade_messages,
             "workflow_resource_parameters": self._workflow_resource_parameters(trans, stored, workflow),
         }

From 43d918fa8cb1dabd9d7d95ed33d65a945a3b11c4 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sun, 12 May 2024 00:14:38 +0300
Subject: [PATCH 03/15] Convert Workflow Run form to composition api

---
 .../components/Workflow/Run/WorkflowRun.vue   | 269 +++++++++---------
 1 file changed, 128 insertions(+), 141 deletions(-)

diff --git a/client/src/components/Workflow/Run/WorkflowRun.vue b/client/src/components/Workflow/Run/WorkflowRun.vue
index 70f82cc704ee..bd544b6af209 100644
--- a/client/src/components/Workflow/Run/WorkflowRun.vue
+++ b/client/src/components/Workflow/Run/WorkflowRun.vue
@@ -1,18 +1,139 @@
+<script setup lang="ts">
+import { computed, onMounted, ref, watch } from "vue";
+
+import { useHistoryItemsStore } from "@/stores/historyItemsStore";
+import { useHistoryStore } from "@/stores/historyStore";
+import { errorMessageAsString } from "@/utils/simple-error";
+
+import { WorkflowRunModel } from "./model";
+import { getRunData } from "./services";
+
+import LoadingSpan from "@/components/LoadingSpan.vue";
+import WorkflowRunForm from "@/components/Workflow/Run/WorkflowRunForm.vue";
+import WorkflowRunFormSimple from "@/components/Workflow/Run/WorkflowRunFormSimple.vue";
+import WorkflowRunSuccess from "@/components/Workflow/Run/WorkflowRunSuccess.vue";
+
+const historyStore = useHistoryStore();
+const historyItemsStore = useHistoryItemsStore();
+
+interface Props {
+    workflowId: string;
+    preferSimpleForm?: boolean;
+    simpleFormTargetHistory?: string;
+    simpleFormUseJobCache?: boolean;
+}
+
+const props = withDefaults(defineProps<Props>(), {
+    preferSimpleForm: false,
+    simpleFormTargetHistory: "current",
+    simpleFormUseJobCache: false,
+});
+
+const formError = ref("");
+const loading = ref(true);
+const hasUpgradeMessages = ref(false);
+const hasStepVersionChanges = ref(false);
+const invocations = ref([]);
+const simpleForm = ref(false);
+const submissionError = ref("");
+const workflowName = ref("");
+const workflowModel: any = ref(null);
+
+const currentHistoryId = computed(() => historyStore.currentHistoryId);
+const editorLink = computed(() => `/workflows/edit?id=${props.workflowId}`);
+const historyStatusKey = computed(() => `${currentHistoryId.value}_${lastUpdateTime.value}`);
+const lastUpdateTime = computed(() => historyItemsStore.lastUpdateTime);
+
+function handleInvocations(incomingInvocations: any) {
+    invocations.value = incomingInvocations;
+    // make sure any new histories are added to historyStore
+    invocations.value.forEach((invocation: any) => {
+        historyStore.getHistoryById(invocation.history_id);
+    });
+}
+
+function handleSubmissionError(error: string) {
+    submissionError.value = errorMessageAsString(error);
+}
+
+function loadRun() {
+    getRunData(props.workflowId)
+        .then((runData) => {
+            const incomingModel = new WorkflowRunModel(runData);
+            simpleForm.value = props.preferSimpleForm;
+            if (simpleForm.value) {
+                // These only work with PJA - the API doesn't evaluate them at
+                // all outside that context currently. The main workflow form renders
+                // these dynamically and takes care of all the validation and setup details
+                // on the frontend. If these are implemented on the backend at some
+                // point this restriction can be lifted.
+                if (incomingModel.hasReplacementParametersInToolForm) {
+                    console.log("cannot render simple workflow form - has ${} values in tool steps");
+                    simpleForm.value = false;
+                }
+                // If there are required parameters in a tool form (a disconnected runtime
+                // input), we have to render the tool form steps and cannot use the
+                // simplified tool form.
+                if (incomingModel.hasOpenToolSteps) {
+                    console.log(
+                        "cannot render simple workflow form - one or more tools have disconnected runtime inputs"
+                    );
+                    simpleForm.value = false;
+                }
+                // Just render the whole form for resource request parameters (kind of
+                // niche - I'm not sure anyone is using these currently anyway).
+                if (incomingModel.hasWorkflowResourceParameters) {
+                    console.log(`Cannot render simple workflow form - workflow resource parameters are configured`);
+                    simpleForm.value = false;
+                }
+            }
+            hasUpgradeMessages.value = incomingModel.hasUpgradeMessages;
+            hasStepVersionChanges.value = incomingModel.hasStepVersionChanges;
+            workflowName.value = incomingModel.name;
+            workflowModel.value = incomingModel;
+            loading.value = false;
+        })
+        .catch((response) => {
+            formError.value = errorMessageAsString(response);
+        });
+}
+
+function showAdvanced() {
+    simpleForm.value = false;
+}
+
+onMounted(() => {
+    loadRun();
+});
+
+watch(
+    () => historyStatusKey.value,
+    () => {
+        if (invocations.value.length === 0) {
+            loadRun();
+        }
+    }
+);
+</script>
+
 <template>
     <span>
-        <b-alert v-if="error" variant="danger" show>
+        <b-alert v-if="formError" variant="danger" show>
             <h2 class="h-text">Workflow cannot be executed. Please resolve the following issue:</h2>
-            {{ error }}
+            {{ formError }}
         </b-alert>
         <span v-else>
             <b-alert v-if="loading" variant="info" show>
                 <LoadingSpan message="Loading workflow run data" />
             </b-alert>
-            <WorkflowRunSuccess v-else-if="!!invocations" :invocations="invocations" :workflow-name="workflowName" />
+            <WorkflowRunSuccess
+                v-else-if="invocations.length > 0"
+                :invocations="invocations"
+                :workflow-name="workflowName" />
             <div v-else class="ui-form-composite">
                 <b-alert v-if="hasUpgradeMessages || hasStepVersionChanges" class="mb-4" variant="warning" show>
-                    The <b>`{{ model.name }}`</b> workflow may contain tools which have changed since it was last saved
-                    or some error have been detected. Please
+                    The <b>`{{ workflowName }}`</b> workflow may contain tools which have changed since it was last
+                    saved or some error have been detected. Please
                     <a :to="editorLink" :href="editorLink">click here to edit and review the issues</a> before running
                     this workflow.
                 </b-alert>
@@ -22,7 +143,7 @@
                     </b-alert>
                     <WorkflowRunFormSimple
                         v-else-if="simpleForm"
-                        :model="model"
+                        :model="workflowModel"
                         :target-history="simpleFormTargetHistory"
                         :use-job-cache="simpleFormUseJobCache"
                         @submissionSuccess="handleInvocations"
@@ -30,7 +151,7 @@
                         @showAdvanced="showAdvanced" />
                     <WorkflowRunForm
                         v-else
-                        :model="model"
+                        :model="workflowModel"
                         @submissionSuccess="handleInvocations"
                         @submissionError="handleSubmissionError" />
                 </div>
@@ -38,137 +159,3 @@
         </span>
     </span>
 </template>
-
-<script>
-import LoadingSpan from "components/LoadingSpan";
-import { mapState } from "pinia";
-import { useHistoryItemsStore } from "stores/historyItemsStore";
-import { errorMessageAsString } from "utils/simple-error";
-
-import { useHistoryStore } from "@/stores/historyStore";
-
-import { WorkflowRunModel } from "./model";
-import { getRunData } from "./services";
-import WorkflowRunForm from "./WorkflowRunForm";
-import WorkflowRunFormSimple from "./WorkflowRunFormSimple";
-import WorkflowRunSuccess from "./WorkflowRunSuccess";
-
-export default {
-    components: {
-        LoadingSpan,
-        WorkflowRunSuccess,
-        WorkflowRunForm,
-        WorkflowRunFormSimple,
-    },
-    props: {
-        workflowId: {
-            type: String,
-            required: true,
-        },
-        preferSimpleForm: {
-            type: Boolean,
-            default: false,
-        },
-        simpleFormTargetHistory: {
-            type: String,
-            default: "current",
-        },
-        simpleFormUseJobCache: {
-            type: Boolean,
-            default: false,
-        },
-    },
-    data() {
-        return {
-            error: null,
-            loading: true,
-            hasUpgradeMessages: false,
-            hasStepVersionChanges: false,
-            workflowName: "",
-            invocations: null,
-            simpleForm: null,
-            submissionError: null,
-            model: null,
-        };
-    },
-    computed: {
-        ...mapState(useHistoryStore, ["currentHistoryId", "getHistoryById"]),
-        ...mapState(useHistoryItemsStore, ["lastUpdateTime"]),
-        editorLink() {
-            return `/workflows/edit?id=${this.model.workflowId}`;
-        },
-        historyStatusKey() {
-            return `${this.currentHistoryId}_${this.lastUpdateTime}`;
-        },
-    },
-    watch: {
-        historyStatusKey() {
-            if (!this.invocations) {
-                this.loadRun();
-            }
-        },
-    },
-    created() {
-        this.loadRun();
-    },
-    methods: {
-        handleInvocations(invocations) {
-            this.invocations = invocations;
-            // make sure any new histories are added to historyStore
-            this.invocations.forEach((invocation) => {
-                this.getHistoryById(invocation.history_id);
-            });
-        },
-        handleSubmissionError(error) {
-            this.submissionError = errorMessageAsString(error);
-        },
-        loadRun() {
-            getRunData(this.workflowId)
-                .then((runData) => {
-                    this.loading = false;
-                    const model = new WorkflowRunModel(runData);
-                    let simpleForm = this.preferSimpleForm;
-                    if (simpleForm) {
-                        // These only work with PJA - the API doesn't evaluate them at
-                        // all outside that context currently. The main workflow form renders
-                        // these dynamically and takes care of all the validation and setup details
-                        // on the frontend. If these are implemented on the backend at some
-                        // point this restriction can be lifted.
-                        if (model.hasReplacementParametersInToolForm) {
-                            console.log("cannot render simple workflow form - has ${} values in tool steps");
-                            simpleForm = false;
-                        }
-                        // If there are required parameters in a tool form (a disconnected runtime
-                        // input), we have to render the tool form steps and cannot use the
-                        // simplified tool form.
-                        if (model.hasOpenToolSteps) {
-                            console.log(
-                                "cannot render simple workflow form - one or more tools have disconnected runtime inputs"
-                            );
-                            simpleForm = false;
-                        }
-                        // Just render the whole form for resource request parameters (kind of
-                        // niche - I'm not sure anyone is using these currently anyway).
-                        if (model.hasWorkflowResourceParameters) {
-                            console.log(
-                                `Cannot render simple workflow form - workflow resource parameters are configured`
-                            );
-                            simpleForm = false;
-                        }
-                    }
-                    this.simpleForm = simpleForm;
-                    this.model = model;
-                    this.hasUpgradeMessages = model.hasUpgradeMessages;
-                    this.hasStepVersionChanges = model.hasStepVersionChanges;
-                    this.workflowName = this.model.name;
-                })
-                .catch((response) => {
-                    this.error = errorMessageAsString(response);
-                });
-        },
-        showAdvanced() {
-            this.simpleForm = false;
-        },
-    },
-};
-</script>

From 20cd463fd56e351953f8370e7c8da2aa7c98b457 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sun, 12 May 2024 00:17:03 +0300
Subject: [PATCH 04/15] Directly import bootstrap vue components into workflow
 run wrapper

---
 .../src/components/Workflow/Run/WorkflowRun.vue | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/client/src/components/Workflow/Run/WorkflowRun.vue b/client/src/components/Workflow/Run/WorkflowRun.vue
index bd544b6af209..14aaf0eae05e 100644
--- a/client/src/components/Workflow/Run/WorkflowRun.vue
+++ b/client/src/components/Workflow/Run/WorkflowRun.vue
@@ -1,4 +1,5 @@
 <script setup lang="ts">
+import { BAlert } from "bootstrap-vue";
 import { computed, onMounted, ref, watch } from "vue";
 
 import { useHistoryItemsStore } from "@/stores/historyItemsStore";
@@ -118,29 +119,29 @@ watch(
 
 <template>
     <span>
-        <b-alert v-if="formError" variant="danger" show>
+        <BAlert v-if="formError" variant="danger" show>
             <h2 class="h-text">Workflow cannot be executed. Please resolve the following issue:</h2>
             {{ formError }}
-        </b-alert>
+        </BAlert>
         <span v-else>
-            <b-alert v-if="loading" variant="info" show>
+            <BAlert v-if="loading" variant="info" show>
                 <LoadingSpan message="Loading workflow run data" />
-            </b-alert>
+            </BAlert>
             <WorkflowRunSuccess
                 v-else-if="invocations.length > 0"
                 :invocations="invocations"
                 :workflow-name="workflowName" />
             <div v-else class="ui-form-composite">
-                <b-alert v-if="hasUpgradeMessages || hasStepVersionChanges" class="mb-4" variant="warning" show>
+                <BAlert v-if="hasUpgradeMessages || hasStepVersionChanges" class="mb-4" variant="warning" show>
                     The <b>`{{ workflowName }}`</b> workflow may contain tools which have changed since it was last
                     saved or some error have been detected. Please
                     <a :to="editorLink" :href="editorLink">click here to edit and review the issues</a> before running
                     this workflow.
-                </b-alert>
+                </BAlert>
                 <div v-else>
-                    <b-alert v-if="submissionError" class="mb-4" variant="danger" show>
+                    <BAlert v-if="submissionError" class="mb-4" variant="danger" show>
                         Workflow submission failed: {{ submissionError }}
-                    </b-alert>
+                    </BAlert>
                     <WorkflowRunFormSimple
                         v-else-if="simpleForm"
                         :model="workflowModel"

From 921c1b4a5b728aef8be760c933e5cdf08e0221aa Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sun, 12 May 2024 00:20:24 +0300
Subject: [PATCH 05/15] Use router link in workflow run form

---
 client/src/components/Workflow/Run/WorkflowRun.vue | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/client/src/components/Workflow/Run/WorkflowRun.vue b/client/src/components/Workflow/Run/WorkflowRun.vue
index 14aaf0eae05e..0aec16a9c9ab 100644
--- a/client/src/components/Workflow/Run/WorkflowRun.vue
+++ b/client/src/components/Workflow/Run/WorkflowRun.vue
@@ -1,6 +1,7 @@
 <script setup lang="ts">
 import { BAlert } from "bootstrap-vue";
 import { computed, onMounted, ref, watch } from "vue";
+import { RouterLink } from "vue-router";
 
 import { useHistoryItemsStore } from "@/stores/historyItemsStore";
 import { useHistoryStore } from "@/stores/historyStore";
@@ -132,10 +133,10 @@ watch(
                 :invocations="invocations"
                 :workflow-name="workflowName" />
             <div v-else class="ui-form-composite">
-                <BAlert v-if="hasUpgradeMessages || hasStepVersionChanges" class="mb-4" variant="warning" show>
+                <BAlert v-if="!hasUpgradeMessages || hasStepVersionChanges" class="mb-4" variant="warning" show>
                     The <b>`{{ workflowName }}`</b> workflow may contain tools which have changed since it was last
                     saved or some error have been detected. Please
-                    <a :to="editorLink" :href="editorLink">click here to edit and review the issues</a> before running
+                    <RouterLink :to="editorLink">click here to edit and review the issues</RouterLink> before running
                     this workflow.
                 </BAlert>
                 <div v-else>

From ce27d7c4dc807e08d66f8e4aeca52f1176411158 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sun, 12 May 2024 01:01:35 +0300
Subject: [PATCH 06/15] Add check to evaluate workflow owner in run workflow
 form

---
 client/src/api/index.ts                            | 3 ++-
 client/src/components/Workflow/Run/WorkflowRun.vue | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/client/src/api/index.ts b/client/src/api/index.ts
index ec217a321012..99d5ad3b1bed 100644
--- a/client/src/api/index.ts
+++ b/client/src/api/index.ts
@@ -213,9 +213,10 @@ export interface User extends QuotaUsageResponse {
 }
 
 export interface AnonymousUser {
+    id: undefined;
     isAnonymous: true;
-    username?: string;
     is_admin?: false;
+    username?: string;
 }
 
 export type GenericUser = User | AnonymousUser;
diff --git a/client/src/components/Workflow/Run/WorkflowRun.vue b/client/src/components/Workflow/Run/WorkflowRun.vue
index 0aec16a9c9ab..084de02a0369 100644
--- a/client/src/components/Workflow/Run/WorkflowRun.vue
+++ b/client/src/components/Workflow/Run/WorkflowRun.vue
@@ -1,10 +1,12 @@
 <script setup lang="ts">
 import { BAlert } from "bootstrap-vue";
+import { storeToRefs } from "pinia";
 import { computed, onMounted, ref, watch } from "vue";
 import { RouterLink } from "vue-router";
 
 import { useHistoryItemsStore } from "@/stores/historyItemsStore";
 import { useHistoryStore } from "@/stores/historyStore";
+import { useUserStore } from "@/stores/userStore";
 import { errorMessageAsString } from "@/utils/simple-error";
 
 import { WorkflowRunModel } from "./model";
@@ -17,6 +19,7 @@ import WorkflowRunSuccess from "@/components/Workflow/Run/WorkflowRunSuccess.vue
 
 const historyStore = useHistoryStore();
 const historyItemsStore = useHistoryItemsStore();
+const { currentUser } = storeToRefs(useUserStore());
 
 interface Props {
     workflowId: string;
@@ -44,6 +47,7 @@ const workflowModel: any = ref(null);
 const currentHistoryId = computed(() => historyStore.currentHistoryId);
 const editorLink = computed(() => `/workflows/edit?id=${props.workflowId}`);
 const historyStatusKey = computed(() => `${currentHistoryId.value}_${lastUpdateTime.value}`);
+const isOwner = computed(() => currentUser.value?.id === workflowModel.value.runData.id);
 const lastUpdateTime = computed(() => historyItemsStore.lastUpdateTime);
 
 function handleInvocations(incomingInvocations: any) {

From a0f83b23173188789dd46fb9da4378716ca6b7ef Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sun, 12 May 2024 01:15:35 +0300
Subject: [PATCH 07/15] Use username as owner in workflow run dict for
 consistency with other context

---
 client/src/components/Workflow/Run/WorkflowRun.vue | 2 +-
 lib/galaxy/managers/workflows.py                   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/client/src/components/Workflow/Run/WorkflowRun.vue b/client/src/components/Workflow/Run/WorkflowRun.vue
index 084de02a0369..2708433adc2d 100644
--- a/client/src/components/Workflow/Run/WorkflowRun.vue
+++ b/client/src/components/Workflow/Run/WorkflowRun.vue
@@ -47,7 +47,7 @@ const workflowModel: any = ref(null);
 const currentHistoryId = computed(() => historyStore.currentHistoryId);
 const editorLink = computed(() => `/workflows/edit?id=${props.workflowId}`);
 const historyStatusKey = computed(() => `${currentHistoryId.value}_${lastUpdateTime.value}`);
-const isOwner = computed(() => currentUser.value?.id === workflowModel.value.runData.id);
+const isOwner = computed(() => currentUser.value?.username === workflowModel.value.runData.owner);
 const lastUpdateTime = computed(() => historyItemsStore.lastUpdateTime);
 
 function handleInvocations(incomingInvocations: any) {
diff --git a/lib/galaxy/managers/workflows.py b/lib/galaxy/managers/workflows.py
index b2f17de32871..35089bc5e4a3 100644
--- a/lib/galaxy/managers/workflows.py
+++ b/lib/galaxy/managers/workflows.py
@@ -1046,9 +1046,9 @@ def _workflow_to_dict_run(self, trans, stored, workflow, history=None):
             "id": trans.app.security.encode_id(stored.id),
             "history_id": trans.app.security.encode_id(history.id) if history else None,
             "name": stored.name,
+            "owner": stored.user.username,
             "steps": step_models,
             "step_version_changes": step_version_changes,
-            "user_id": trans.app.security.encode_id(stored.user_id),
             "has_upgrade_messages": has_upgrade_messages,
             "workflow_resource_parameters": self._workflow_resource_parameters(trans, stored, workflow),
         }

From 9b6702f3bf9629a1abb24344d559e6cd194bd92e Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sun, 12 May 2024 01:20:52 +0300
Subject: [PATCH 08/15] Add handler and link to import workflow if workflow is
 not owned by user

---
 client/src/components/Workflow/Run/WorkflowRun.vue | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/client/src/components/Workflow/Run/WorkflowRun.vue b/client/src/components/Workflow/Run/WorkflowRun.vue
index 2708433adc2d..3a5a19cb38f8 100644
--- a/client/src/components/Workflow/Run/WorkflowRun.vue
+++ b/client/src/components/Workflow/Run/WorkflowRun.vue
@@ -104,6 +104,8 @@ function loadRun() {
         });
 }
 
+function onImport() {}
+
 function showAdvanced() {
     simpleForm.value = false;
 }
@@ -138,10 +140,13 @@ watch(
                 :workflow-name="workflowName" />
             <div v-else class="ui-form-composite">
                 <BAlert v-if="!hasUpgradeMessages || hasStepVersionChanges" class="mb-4" variant="warning" show>
-                    The <b>`{{ workflowName }}`</b> workflow may contain tools which have changed since it was last
-                    saved or some error have been detected. Please
-                    <RouterLink :to="editorLink">click here to edit and review the issues</RouterLink> before running
-                    this workflow.
+                    <span>
+                        The <b>`{{ workflowName }}`</b> workflow may contain tools which have changed since it was last
+                        saved or some error have been detected. Please
+                    </span>
+                    <RouterLink v-if="isOwner" :to="editorLink">click here to edit and review the issues</RouterLink>
+                    <BLink v-else @click="onImport">click here to import the workflow and review the issues</BLink>
+                    <span>before running this workflow.</span>
                 </BAlert>
                 <div v-else>
                     <BAlert v-if="submissionError" class="mb-4" variant="danger" show>

From 91828024f9450f14ad597bf52e450d998a401324 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sun, 12 May 2024 01:28:23 +0300
Subject: [PATCH 09/15] Add handler to import and edit workflow

---
 client/src/components/Workflow/Run/WorkflowRun.vue | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/client/src/components/Workflow/Run/WorkflowRun.vue b/client/src/components/Workflow/Run/WorkflowRun.vue
index 3a5a19cb38f8..e6bcb0cb1071 100644
--- a/client/src/components/Workflow/Run/WorkflowRun.vue
+++ b/client/src/components/Workflow/Run/WorkflowRun.vue
@@ -3,7 +3,9 @@ import { BAlert } from "bootstrap-vue";
 import { storeToRefs } from "pinia";
 import { computed, onMounted, ref, watch } from "vue";
 import { RouterLink } from "vue-router";
+import { useRouter } from "vue-router/composables";
 
+import { copyWorkflow } from "@/components/Workflow/workflows.services";
 import { useHistoryItemsStore } from "@/stores/historyItemsStore";
 import { useHistoryStore } from "@/stores/historyStore";
 import { useUserStore } from "@/stores/userStore";
@@ -20,6 +22,7 @@ import WorkflowRunSuccess from "@/components/Workflow/Run/WorkflowRunSuccess.vue
 const historyStore = useHistoryStore();
 const historyItemsStore = useHistoryItemsStore();
 const { currentUser } = storeToRefs(useUserStore());
+const router = useRouter();
 
 interface Props {
     workflowId: string;
@@ -104,7 +107,10 @@ function loadRun() {
         });
 }
 
-function onImport() {}
+async function onImport() {
+    const response = await copyWorkflow(props.workflowId, workflowModel.value.runData.owner);
+    router.push(`/workflows/edit?id=${response.id}`);
+}
 
 function showAdvanced() {
     simpleForm.value = false;

From 0dd1b78d8f8a7489527a315c1c8a6fc1dc93cf7b Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sun, 12 May 2024 01:31:12 +0300
Subject: [PATCH 10/15] Fix upgrade condition in run form

---
 client/src/components/Workflow/Run/WorkflowRun.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/src/components/Workflow/Run/WorkflowRun.vue b/client/src/components/Workflow/Run/WorkflowRun.vue
index e6bcb0cb1071..56cf8b267dad 100644
--- a/client/src/components/Workflow/Run/WorkflowRun.vue
+++ b/client/src/components/Workflow/Run/WorkflowRun.vue
@@ -145,7 +145,7 @@ watch(
                 :invocations="invocations"
                 :workflow-name="workflowName" />
             <div v-else class="ui-form-composite">
-                <BAlert v-if="!hasUpgradeMessages || hasStepVersionChanges" class="mb-4" variant="warning" show>
+                <BAlert v-if="hasUpgradeMessages || hasStepVersionChanges" class="mb-4" variant="warning" show>
                     <span>
                         The <b>`{{ workflowName }}`</b> workflow may contain tools which have changed since it was last
                         saved or some error have been detected. Please

From 797faa17ba7c656b6af15c7060cd5c133d980fde Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sun, 12 May 2024 01:33:58 +0300
Subject: [PATCH 11/15] Add missing BLink import to workflow run form

---
 client/src/components/Workflow/Run/WorkflowRun.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/src/components/Workflow/Run/WorkflowRun.vue b/client/src/components/Workflow/Run/WorkflowRun.vue
index 56cf8b267dad..3a2df240cd24 100644
--- a/client/src/components/Workflow/Run/WorkflowRun.vue
+++ b/client/src/components/Workflow/Run/WorkflowRun.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-import { BAlert } from "bootstrap-vue";
+import { BAlert, BLink } from "bootstrap-vue";
 import { storeToRefs } from "pinia";
 import { computed, onMounted, ref, watch } from "vue";
 import { RouterLink } from "vue-router";

From 63572559aa70967d30a8033828af4eafbd0c740e Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sun, 12 May 2024 10:01:41 +0300
Subject: [PATCH 12/15] Fix user typing

---
 client/src/api/index.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/src/api/index.ts b/client/src/api/index.ts
index 99d5ad3b1bed..1b1aa6f66c93 100644
--- a/client/src/api/index.ts
+++ b/client/src/api/index.ts
@@ -213,7 +213,7 @@ export interface User extends QuotaUsageResponse {
 }
 
 export interface AnonymousUser {
-    id: undefined;
+    id?: string;
     isAnonymous: true;
     is_admin?: false;
     username?: string;

From cba8413fa443e515616196e754b53caf867a17f2 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sun, 12 May 2024 10:57:51 +0300
Subject: [PATCH 13/15] Adjust test cases for modified workflow run form

---
 client/src/components/LoadingSpan.vue         |  4 +-
 .../Workflow/Run/WorkflowRun.test.js          | 56 ++++++++++---------
 .../components/Workflow/Run/WorkflowRun.vue   | 24 ++++++--
 client/src/utils/navigation/navigation.yml    |  2 +-
 4 files changed, 52 insertions(+), 34 deletions(-)

diff --git a/client/src/components/LoadingSpan.vue b/client/src/components/LoadingSpan.vue
index 3babd0a618d7..527dc6c39e85 100644
--- a/client/src/components/LoadingSpan.vue
+++ b/client/src/components/LoadingSpan.vue
@@ -1,7 +1,9 @@
 <template>
     <span>
         <span :class="spinnerClasses" title="loading"></span>
-        <span v-if="!spinnerOnly" class="loading-message">{{ message }}.<span class="blinking">..</span></span>
+        <span v-if="!spinnerOnly" class="loading-message" data-description="loading message">
+            {{ message }}.<span class="blinking">..</span>
+        </span>
     </span>
 </template>
 <script>
diff --git a/client/src/components/Workflow/Run/WorkflowRun.test.js b/client/src/components/Workflow/Run/WorkflowRun.test.js
index 3d39b78251a8..55c613d528d0 100644
--- a/client/src/components/Workflow/Run/WorkflowRun.test.js
+++ b/client/src/components/Workflow/Run/WorkflowRun.test.js
@@ -1,7 +1,7 @@
 import { createTestingPinia } from "@pinia/testing";
-import { createLocalVue, shallowMount } from "@vue/test-utils";
+import { createLocalVue, mount } from "@vue/test-utils";
+import flushPromises from "flush-promises";
 import { PiniaVuePlugin } from "pinia";
-import { watchForChange } from "tests/jest/helpers";
 
 import { getRunData } from "./services";
 import sampleRunData1 from "./testdata/run1.json";
@@ -35,7 +35,7 @@ describe("WorkflowRun.vue", () => {
         const propsData = { workflowId: run1WorkflowId };
         localVue = createLocalVue();
         localVue.use(PiniaVuePlugin);
-        wrapper = shallowMount(WorkflowRun, {
+        wrapper = mount(WorkflowRun, {
             propsData: propsData,
             localVue,
             pinia: createTestingPinia(),
@@ -43,29 +43,28 @@ describe("WorkflowRun.vue", () => {
     });
 
     it("loads run data from API and parses it into a WorkflowRunModel object", async () => {
-        // waits for vue to render wrapper
-        await localVue.nextTick();
-
-        expect(wrapper.vm.loading).toBe(true);
-        expect(wrapper.vm.error).toBeNull();
-        expect(wrapper.vm.model).toBeNull();
+        const loadingTag = "[data-description='loading message']";
+        expect(wrapper.find(loadingTag).exists()).toBeTruthy();
+        expect(wrapper.vm.workflowError).toBe("");
+        expect(wrapper.vm.workflowModel).toBeNull();
 
-        await watchForChange({ vm: wrapper.vm, propName: "loading" });
+        await flushPromises();
+        await wrapper.vm.$nextTick();
 
-        expect(wrapper.vm.error).toBeNull();
-        expect(wrapper.vm.loading).toBe(false);
+        expect(wrapper.find(loadingTag).exists()).toBeFalsy();
         expect(wrapper.vm.simpleForm).toBe(false);
-        const model = wrapper.vm.model;
-        expect(model).not.toBeNull();
-        expect(model.workflowId).toBe(run1WorkflowId);
-        expect(model.name).toBe("Cool Test Workflow");
-        expect(model.historyId).toBe("8f7a155755f10e73");
-        expect(model.hasUpgradeMessages).toBe(false);
-        expect(model.hasStepVersionChanges).toBe(false);
-        expect(model.wpInputs.wf_param.label).toBe("wf_param");
+
+        const workflowModel = wrapper.vm.workflowModel;
+        expect(workflowModel).not.toBeNull();
+        expect(workflowModel.workflowId).toBe(run1WorkflowId);
+        expect(workflowModel.name).toBe("Cool Test Workflow");
+        expect(workflowModel.historyId).toBe("8f7a155755f10e73");
+        expect(workflowModel.hasUpgradeMessages).toBe(false);
+        expect(workflowModel.hasStepVersionChanges).toBe(false);
+        expect(workflowModel.wpInputs.wf_param.label).toBe("wf_param");
         // all steps are expanded since data and parameter steps are expanded by default,
         // the same is true for tools with unconnected data inputs.
-        model.steps.forEach((step) => {
+        workflowModel.steps.forEach((step) => {
             expect(step.expanded).toBe(true);
         });
     });
@@ -75,17 +74,20 @@ describe("WorkflowRun.vue", () => {
         await localVue.nextTick();
 
         expect(wrapper.vm.loading).toBe(true);
-        expect(wrapper.vm.error).toBeNull();
-        expect(wrapper.vm.model).toBeNull();
+        expect(wrapper.vm.workflowError).toBe("");
+        expect(wrapper.vm.workflowModel).toBeNull();
 
-        await watchForChange({ vm: wrapper.vm, propName: "loading" });
+        await flushPromises();
+        await wrapper.vm.$nextTick();
 
-        expect(wrapper.vm.error).toBeNull();
+        expect(wrapper.vm.workflowError).toBe("");
         expect(wrapper.vm.loading).toBe(false);
-        expect(wrapper.find("b-alert-stub").exists()).toBe(false);
+        expect(wrapper.find(".alert-danger").exists()).toBe(false);
         wrapper.vm.handleSubmissionError("Some exception here");
+
         await localVue.nextTick();
+
         expect(wrapper.vm.submissionError).toBe("Some exception here");
-        expect(wrapper.find("b-alert-stub").attributes("variant")).toEqual("danger");
+        expect(wrapper.find(".alert-danger").exists()).toBe(true);
     });
 });
diff --git a/client/src/components/Workflow/Run/WorkflowRun.vue b/client/src/components/Workflow/Run/WorkflowRun.vue
index 3a2df240cd24..3e6f607efcac 100644
--- a/client/src/components/Workflow/Run/WorkflowRun.vue
+++ b/client/src/components/Workflow/Run/WorkflowRun.vue
@@ -37,13 +37,13 @@ const props = withDefaults(defineProps<Props>(), {
     simpleFormUseJobCache: false,
 });
 
-const formError = ref("");
 const loading = ref(true);
 const hasUpgradeMessages = ref(false);
 const hasStepVersionChanges = ref(false);
 const invocations = ref([]);
 const simpleForm = ref(false);
 const submissionError = ref("");
+const workflowError = ref("");
 const workflowName = ref("");
 const workflowModel: any = ref(null);
 
@@ -103,7 +103,7 @@ function loadRun() {
             loading.value = false;
         })
         .catch((response) => {
-            formError.value = errorMessageAsString(response);
+            workflowError.value = errorMessageAsString(response);
         });
 }
 
@@ -128,13 +128,22 @@ watch(
         }
     }
 );
+
+defineExpose({
+    loading,
+    simpleForm,
+    submissionError,
+    handleSubmissionError,
+    workflowError,
+    workflowModel,
+});
 </script>
 
 <template>
     <span>
-        <BAlert v-if="formError" variant="danger" show>
+        <BAlert v-if="workflowError" variant="danger" show>
             <h2 class="h-text">Workflow cannot be executed. Please resolve the following issue:</h2>
-            {{ formError }}
+            {{ workflowError }}
         </BAlert>
         <span v-else>
             <BAlert v-if="loading" variant="info" show>
@@ -145,7 +154,12 @@ watch(
                 :invocations="invocations"
                 :workflow-name="workflowName" />
             <div v-else class="ui-form-composite">
-                <BAlert v-if="hasUpgradeMessages || hasStepVersionChanges" class="mb-4" variant="warning" show>
+                <BAlert
+                    v-if="hasUpgradeMessages || hasStepVersionChanges"
+                    class="mb-4"
+                    variant="warning"
+                    show
+                    data-description="workflow run warning">
                     <span>
                         The <b>`{{ workflowName }}`</b> workflow may contain tools which have changed since it was last
                         saved or some error have been detected. Please
diff --git a/client/src/utils/navigation/navigation.yml b/client/src/utils/navigation/navigation.yml
index 58246b2db03c..eafe5777c32f 100644
--- a/client/src/utils/navigation/navigation.yml
+++ b/client/src/utils/navigation/navigation.yml
@@ -663,7 +663,7 @@ trs_import:
 
 workflow_run:
   selectors:
-    warning: ".ui-form-composite-messages .alert-warning"
+    warning: '[data-description="workflow run warning"]'
     input_div: "[step-label='${label}']"
     input_data_div: "[step-label='${label}'] .multiselect"
     # TODO: put step labels in the DOM ideally

From 8e8a8f0b4652bc0df06e833b2f2a6cb813f9ade5 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sun, 12 May 2024 12:47:47 +0300
Subject: [PATCH 14/15] Adjust selenium test warning message case

---
 lib/galaxy_test/selenium/test_workflow_run.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/galaxy_test/selenium/test_workflow_run.py b/lib/galaxy_test/selenium/test_workflow_run.py
index afb6085b98bf..fea087ac06dc 100644
--- a/lib/galaxy_test/selenium/test_workflow_run.py
+++ b/lib/galaxy_test/selenium/test_workflow_run.py
@@ -177,7 +177,7 @@ def test_execution_with_tool_upgrade(self):
         self.workflow_run_with_name(name)
         self.sleep_for(self.wait_types.UX_TRANSITION)
         # Check that this tool form contains a warning about different versions.
-        self.assert_message(self.components.workflow_run.warning, contains="different versions")
+        self.assert_message(self.components.workflow_run.warning, contains="tools which have changed")
         self.screenshot("workflow_run_tool_upgrade")
 
     @selenium_test
@@ -189,7 +189,7 @@ def test_run_form_safe_upgrade_handling(self):
         name = self.workflow_upload_yaml_with_random_name(workflow_with_rules_json, exact_tools=True)
         self.workflow_run_with_name(name)
         self.sleep_for(self.wait_types.UX_TRANSITION)
-        self.assert_message(self.components.workflow_run.warning, contains="different versions")
+        self.assert_message(self.components.workflow_run.warning, contains="tools which have changed")
         # 1.0.0 is a version that exists in WORKFLOW_SAFE_TOOL_VERSION_UPDATES
         workflow_with_rules["steps"]["apply"]["tool_version"] = "1.0.0"
         workflow_with_rules_json = json.dumps(workflow_with_rules)

From 1b9ff327a23500e2b9791c540089a8b12cf40818 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Mon, 13 May 2024 09:09:25 +0300
Subject: [PATCH 15/15] Adjust warning message in workflow run form

---
 client/src/components/Workflow/Run/WorkflowRun.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/src/components/Workflow/Run/WorkflowRun.vue b/client/src/components/Workflow/Run/WorkflowRun.vue
index 3e6f607efcac..cce942b988b4 100644
--- a/client/src/components/Workflow/Run/WorkflowRun.vue
+++ b/client/src/components/Workflow/Run/WorkflowRun.vue
@@ -162,7 +162,7 @@ defineExpose({
                     data-description="workflow run warning">
                     <span>
                         The <b>`{{ workflowName }}`</b> workflow may contain tools which have changed since it was last
-                        saved or some error have been detected. Please
+                        saved or some other problems have been detected. Please
                     </span>
                     <RouterLink v-if="isOwner" :to="editorLink">click here to edit and review the issues</RouterLink>
                     <BLink v-else @click="onImport">click here to import the workflow and review the issues</BLink>