diff --git a/client/src/api/index.ts b/client/src/api/index.ts index ec217a321012..1b1aa6f66c93 100644 --- a/client/src/api/index.ts +++ b/client/src/api/index.ts @@ -213,9 +213,10 @@ export interface User extends QuotaUsageResponse { } export interface AnonymousUser { + id?: string; isAnonymous: true; - username?: string; is_admin?: false; + username?: string; } export type GenericUser = User | AnonymousUser; diff --git a/client/src/components/LoadingSpan.vue b/client/src/components/LoadingSpan.vue index 3babd0a618d7..527dc6c39e85 100644 --- a/client/src/components/LoadingSpan.vue +++ b/client/src/components/LoadingSpan.vue @@ -1,7 +1,9 @@ + - - diff --git a/client/src/utils/navigation/navigation.yml b/client/src/utils/navigation/navigation.yml index 258da5b54560..5b41b7e2200e 100644 --- a/client/src/utils/navigation/navigation.yml +++ b/client/src/utils/navigation/navigation.yml @@ -662,7 +662,7 @@ trs_import: workflow_run: selectors: - warning: ".ui-form-composite-messages .alert-warning" + warning: '[data-description="workflow run warning"]' input_div: "[step-label='${label}']" input_data_div: "[step-label='${label}'] .multiselect" # TODO: put step labels in the DOM ideally diff --git a/lib/galaxy/managers/workflows.py b/lib/galaxy/managers/workflows.py index 563314260d00..35089bc5e4a3 100644 --- a/lib/galaxy/managers/workflows.py +++ b/lib/galaxy/managers/workflows.py @@ -1046,6 +1046,7 @@ def _workflow_to_dict_run(self, trans, stored, workflow, history=None): "id": trans.app.security.encode_id(stored.id), "history_id": trans.app.security.encode_id(history.id) if history else None, "name": stored.name, + "owner": stored.user.username, "steps": step_models, "step_version_changes": step_version_changes, "has_upgrade_messages": has_upgrade_messages, diff --git a/lib/galaxy_test/selenium/test_workflow_run.py b/lib/galaxy_test/selenium/test_workflow_run.py index afb6085b98bf..fea087ac06dc 100644 --- a/lib/galaxy_test/selenium/test_workflow_run.py +++ b/lib/galaxy_test/selenium/test_workflow_run.py @@ -177,7 +177,7 @@ def test_execution_with_tool_upgrade(self): self.workflow_run_with_name(name) self.sleep_for(self.wait_types.UX_TRANSITION) # Check that this tool form contains a warning about different versions. - self.assert_message(self.components.workflow_run.warning, contains="different versions") + self.assert_message(self.components.workflow_run.warning, contains="tools which have changed") self.screenshot("workflow_run_tool_upgrade") @selenium_test @@ -189,7 +189,7 @@ def test_run_form_safe_upgrade_handling(self): name = self.workflow_upload_yaml_with_random_name(workflow_with_rules_json, exact_tools=True) self.workflow_run_with_name(name) self.sleep_for(self.wait_types.UX_TRANSITION) - self.assert_message(self.components.workflow_run.warning, contains="different versions") + self.assert_message(self.components.workflow_run.warning, contains="tools which have changed") # 1.0.0 is a version that exists in WORKFLOW_SAFE_TOOL_VERSION_UPDATES workflow_with_rules["steps"]["apply"]["tool_version"] = "1.0.0" workflow_with_rules_json = json.dumps(workflow_with_rules)