From 34404bd87583a0a5a0d6cf42603af44aae8fdfcb Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Wed, 15 May 2024 14:15:00 +0200 Subject: [PATCH] Drop redundant error message There are only two places in the code where we set the job state to error (https://github.com/galaxyproject/galaxy/blob/ad9271cf6a33cb2e22bd7bed72f901e5215309da/lib/galaxy/jobs/handler.py#L722, https://github.com/galaxyproject/galaxy/blob/ad9271cf6a33cb2e22bd7bed72f901e5215309da/lib/galaxy/jobs/handler.py#L733) and both log more specific log messages. --- lib/galaxy/jobs/handler.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/galaxy/jobs/handler.py b/lib/galaxy/jobs/handler.py index 1df3503ffb96..f724bb736b72 100644 --- a/lib/galaxy/jobs/handler.py +++ b/lib/galaxy/jobs/handler.py @@ -569,7 +569,8 @@ def __handle_waiting_jobs(self): self.sa_session.add(dataset_assoc.dataset.dataset) self.sa_session.add(job) elif job_state == JOB_ERROR: - log.error("(%d) Error checking job readiness" % job.id) + # A more informative message is shown wherever the job state is set to error + pass else: log.error("(%d) Job in unknown state '%s'" % (job.id, job_state)) new_waiting_jobs.append(job.id)