From 96cf2f3eb301677038759830fa2721ba1b70861a Mon Sep 17 00:00:00 2001
From: mvdbeek <m.vandenbeek@gmail.com>
Date: Thu, 18 Apr 2024 09:41:29 +0200
Subject: [PATCH] Drop guard ... this shouldn't break or else we need to
 rethink this

---
 lib/galaxy/tools/parameters/__init__.py | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/lib/galaxy/tools/parameters/__init__.py b/lib/galaxy/tools/parameters/__init__.py
index 7e72bf3a9eb1..e56ccdb942e5 100644
--- a/lib/galaxy/tools/parameters/__init__.py
+++ b/lib/galaxy/tools/parameters/__init__.py
@@ -16,7 +16,6 @@
 from .basic import (
     DataCollectionToolParameter,
     DataToolParameter,
-    ParameterValueError,
     SelectToolParameter,
     ToolParameter,
 )
@@ -291,10 +290,8 @@ def params_from_strings(params: Dict[str, Union[Group, ToolParameter]], param_va
             # This would resolve a lot of back and forth in the various to/from methods.
             value = safe_loads(value)
         if param:
-            try:
-                value = param.value_from_basic(value, app, ignore_errors)
-            except ParameterValueError:
-                continue
+            # if ignore_error is true we return the value unmodified
+            value = param.value_from_basic(value, app, ignore_errors)
         rval[key] = value
     return rval