From 515c5cd540fa8c09761ab4e0ef3dc1c98887e92b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Crist=C3=B3bal=20Gallardo?=
 <gallardo@informatik.uni-freiburg.de>
Date: Wed, 29 Sep 2021 18:23:26 +0200
Subject: [PATCH 1/8] Proposed modifications

---
 client/src/snippets.json | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/client/src/snippets.json b/client/src/snippets.json
index d07a7f2..7f6d68e 100644
--- a/client/src/snippets.json
+++ b/client/src/snippets.json
@@ -104,7 +104,7 @@
     "Boolean parameter": {
         "prefix": "gx-boolean-param",
         "body": [
-            "<param argument=\"${1:--}\" type=\"boolean\" truevalue=\"$1\" falsevalue=\"$2\" label=\"$3\" help=\"${4:TODO}\" />"
+            "<param argument=\"${1:--}\" type=\"boolean\" truevalue=\"$1\" falsevalue=\"$2\" checked=\"false\" label=\"$3\" help=\"${4:TODO}\" />"
         ],
         "description": "Boolean parameter"
     },
@@ -125,14 +125,14 @@
     "Data parameter with single required dataset": {
         "prefix": "gx-data-single-param",
         "body": [
-            "<param argument=\"--$1\" type=\"data\" format=\"$2\" label=\"$3\" help=\"${4:TODO}\" />"
+            "<param name=\"$1\" argument=\"--$2\" type=\"data\" format=\"$3\" label=\"$4\" help=\"${5:TODO}\" />"
         ],
         "description": "Data parameter with single required dataset"
     },
     "Data parameter with multiple required datasets": {
         "prefix": "gx-data-multiple-param",
         "body": [
-            "<param argument=\"--$1\" type=\"data\" format=\"$2\" multiple=\"true\" label=\"$3\" help=\"${4:TODO}\" />"
+            "<param name=\"$1\" argument=\"--$2\" type=\"data\" format=\"$3\" multiple=\"true\" label=\"$4\" help=\"${5:TODO}\" />"
         ],
         "description": "Data parameter with multiple required datasets"
     },
@@ -145,6 +145,7 @@
             "            <add value=\"_\" />",
             "        </valid>",
             "    </sanitizer>",
+            "    <validator type=\"regex\">[0-9a-zA-Z_]+</validator>",
             "</param>"
         ],
         "description": "Text parameter with sanitizer"

From 3c54dc9c002090eba025acbe4ba2f31c31ce3951 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Crist=C3=B3bal=20Gallardo?=
 <gallardo@informatik.uni-freiburg.de>
Date: Thu, 30 Sep 2021 10:17:39 +0200
Subject: [PATCH 2/8] Modify order and format

---
 client/src/snippets.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/client/src/snippets.json b/client/src/snippets.json
index 7f6d68e..d32e0f3 100644
--- a/client/src/snippets.json
+++ b/client/src/snippets.json
@@ -125,14 +125,14 @@
     "Data parameter with single required dataset": {
         "prefix": "gx-data-single-param",
         "body": [
-            "<param name=\"$1\" argument=\"--$2\" type=\"data\" format=\"$3\" label=\"$4\" help=\"${5:TODO}\" />"
+            "<param argument=\"${1:--}\" name=\"$1\" type=\"data\" format=\"$2\" label=\"$3\" help=\"${4:TODO}\" />"
         ],
         "description": "Data parameter with single required dataset"
     },
     "Data parameter with multiple required datasets": {
         "prefix": "gx-data-multiple-param",
         "body": [
-            "<param name=\"$1\" argument=\"--$2\" type=\"data\" format=\"$3\" multiple=\"true\" label=\"$4\" help=\"${5:TODO}\" />"
+            "<param argument=\"${1:--}\" name=\"$1\" type=\"data\" format=\"$2\" multiple=\"true\" label=\"$3\" help=\"${4:TODO}\" />"
         ],
         "description": "Data parameter with multiple required datasets"
     },

From 16150c27f0645988ae3c52574e28ca920ca57cc0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Crist=C3=B3bal=20Gallardo?=
 <gallardo@informatik.uni-freiburg.de>
Date: Thu, 30 Sep 2021 10:33:55 +0200
Subject: [PATCH 3/8] Update client/src/snippets.json
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
---
 client/src/snippets.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/src/snippets.json b/client/src/snippets.json
index d32e0f3..607bcaf 100644
--- a/client/src/snippets.json
+++ b/client/src/snippets.json
@@ -125,7 +125,7 @@
     "Data parameter with single required dataset": {
         "prefix": "gx-data-single-param",
         "body": [
-            "<param argument=\"${1:--}\" name=\"$1\" type=\"data\" format=\"$2\" label=\"$3\" help=\"${4:TODO}\" />"
+            "<param argument=\"--${1:}\" name=\"$1\" type=\"data\" format=\"$2\" label=\"$3\" help=\"${4:TODO}\" />"
         ],
         "description": "Data parameter with single required dataset"
     },

From bbace264ced3d42caa8635286a2df6b990231a44 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Crist=C3=B3bal=20Gallardo?=
 <gallardo@informatik.uni-freiburg.de>
Date: Thu, 30 Sep 2021 10:56:29 +0200
Subject: [PATCH 4/8] Update client/src/snippets.json
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
---
 client/src/snippets.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/src/snippets.json b/client/src/snippets.json
index 607bcaf..b85edaf 100644
--- a/client/src/snippets.json
+++ b/client/src/snippets.json
@@ -132,7 +132,7 @@
     "Data parameter with multiple required datasets": {
         "prefix": "gx-data-multiple-param",
         "body": [
-            "<param argument=\"${1:--}\" name=\"$1\" type=\"data\" format=\"$2\" multiple=\"true\" label=\"$3\" help=\"${4:TODO}\" />"
+            "<param argument=\"--${1:}\" name=\"$1\" type=\"data\" format=\"$2\" multiple=\"true\" label=\"$3\" help=\"${4:TODO}\" />"
         ],
         "description": "Data parameter with multiple required datasets"
     },

From b4ebebdf3f6eaf65df362ae7d17fa1dcda936616 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Crist=C3=B3bal=20Gallardo?=
 <gallardo@informatik.uni-freiburg.de>
Date: Sun, 3 Oct 2021 16:25:05 +0200
Subject: [PATCH 5/8] snippets.json

---
 client/src/snippets.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/client/src/snippets.json b/client/src/snippets.json
index b85edaf..fb703f0 100644
--- a/client/src/snippets.json
+++ b/client/src/snippets.json
@@ -125,14 +125,14 @@
     "Data parameter with single required dataset": {
         "prefix": "gx-data-single-param",
         "body": [
-            "<param argument=\"--${1:}\" name=\"$1\" type=\"data\" format=\"$2\" label=\"$3\" help=\"${4:TODO}\" />"
+            "<param argument=\"--${1:}\" type=\"data\" format=\"$2\" label=\"$3\" help=\"${4:TODO}\" />"
         ],
         "description": "Data parameter with single required dataset"
     },
     "Data parameter with multiple required datasets": {
         "prefix": "gx-data-multiple-param",
         "body": [
-            "<param argument=\"--${1:}\" name=\"$1\" type=\"data\" format=\"$2\" multiple=\"true\" label=\"$3\" help=\"${4:TODO}\" />"
+            "<param argument=\"--${1:}\" type=\"data\" format=\"$2\" multiple=\"true\" label=\"$3\" help=\"${4:TODO}\" />"
         ],
         "description": "Data parameter with multiple required datasets"
     },

From f58a88c0c658b82cdeeaf6a2538829eae04fd862 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Crist=C3=B3bal=20Gallardo?=
 <gallardo@informatik.uni-freiburg.de>
Date: Sun, 3 Oct 2021 16:29:17 +0200
Subject: [PATCH 6/8] Undo change argument

---
 client/src/snippets.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/client/src/snippets.json b/client/src/snippets.json
index fb703f0..dd09b98 100644
--- a/client/src/snippets.json
+++ b/client/src/snippets.json
@@ -125,14 +125,14 @@
     "Data parameter with single required dataset": {
         "prefix": "gx-data-single-param",
         "body": [
-            "<param argument=\"--${1:}\" type=\"data\" format=\"$2\" label=\"$3\" help=\"${4:TODO}\" />"
+            "<param  argument=\"--$1\" type=\"data\" format=\"$2\" label=\"$3\" help=\"${4:TODO}\" />"
         ],
         "description": "Data parameter with single required dataset"
     },
     "Data parameter with multiple required datasets": {
         "prefix": "gx-data-multiple-param",
         "body": [
-            "<param argument=\"--${1:}\" type=\"data\" format=\"$2\" multiple=\"true\" label=\"$3\" help=\"${4:TODO}\" />"
+            "<param  argument=\"--$1\" type=\"data\" format=\"$2\" multiple=\"true\" label=\"$3\" help=\"${4:TODO}\" />"
         ],
         "description": "Data parameter with multiple required datasets"
     },

From 310a29aacc924bda3ad5b8b56c79b747e8d47dc3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Crist=C3=B3bal=20Gallardo?=
 <gallardo@informatik.uni-freiburg.de>
Date: Sun, 3 Oct 2021 16:30:18 +0200
Subject: [PATCH 7/8] Remove extra spaces

---
 client/src/snippets.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/client/src/snippets.json b/client/src/snippets.json
index dd09b98..2ac9a2d 100644
--- a/client/src/snippets.json
+++ b/client/src/snippets.json
@@ -125,14 +125,14 @@
     "Data parameter with single required dataset": {
         "prefix": "gx-data-single-param",
         "body": [
-            "<param  argument=\"--$1\" type=\"data\" format=\"$2\" label=\"$3\" help=\"${4:TODO}\" />"
+            "<param argument=\"--$1\" type=\"data\" format=\"$2\" label=\"$3\" help=\"${4:TODO}\" />"
         ],
         "description": "Data parameter with single required dataset"
     },
     "Data parameter with multiple required datasets": {
         "prefix": "gx-data-multiple-param",
         "body": [
-            "<param  argument=\"--$1\" type=\"data\" format=\"$2\" multiple=\"true\" label=\"$3\" help=\"${4:TODO}\" />"
+            "<param argument=\"--$1\" type=\"data\" format=\"$2\" multiple=\"true\" label=\"$3\" help=\"${4:TODO}\" />"
         ],
         "description": "Data parameter with multiple required datasets"
     },

From 3af4e746f5ba284b7616cab7aecfedb71591af3a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Crist=C3=B3bal=20Gallardo?=
 <gallardo@informatik.uni-freiburg.de>
Date: Mon, 4 Oct 2021 12:57:39 +0200
Subject: [PATCH 8/8] Update client/src/snippets.json
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
---
 client/src/snippets.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/src/snippets.json b/client/src/snippets.json
index 2ac9a2d..2d826c4 100644
--- a/client/src/snippets.json
+++ b/client/src/snippets.json
@@ -104,7 +104,7 @@
     "Boolean parameter": {
         "prefix": "gx-boolean-param",
         "body": [
-            "<param argument=\"${1:--}\" type=\"boolean\" truevalue=\"$1\" falsevalue=\"$2\" checked=\"false\" label=\"$3\" help=\"${4:TODO}\" />"
+            "<param argument=\"${1:--}\" type=\"boolean\" truevalue=\"$1\" falsevalue=\"$2\" checked=\"${3|false,true|}\" label=\"$4\" help=\"${5:TODO}\" />"
         ],
         "description": "Boolean parameter"
     },