Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove objects read permission #480

Open
ksuderman opened this issue Jun 29, 2024 · 16 comments · Fixed by #481
Open

Remove objects read permission #480

ksuderman opened this issue Jun 29, 2024 · 16 comments · Fixed by #481
Labels

Comments

@ksuderman
Copy link
Contributor

Galaxy 24.1.1 will include the fix that will allow us to remove read permission for the entire objects directory.

@afgane
Copy link
Contributor

afgane commented Jun 29, 2024

The fix is against release 24.0 actually so we won't have to wait for the next release.

@ksuderman
Copy link
Contributor Author

True, but the branch won't be tagged so we won't get a Docker image built automatically (except for the 24.0-auto image). According to John D 24.1.1 will be released in a few days so it should be ok to wait until then.

@DuttaAnik
Copy link

Hi @ksuderman have you released the 24.1.1 version with the objects folder permission bug fixed?

@ksuderman
Copy link
Contributor Author

Hi @anik, I did not see a notification about the release, but I see galaxy-min:24.1.1 on quay.io. I am testing it now and will report back.

@ksuderman
Copy link
Contributor Author

Our tests are passing and #481 will be merged shortly.

@DuttaAnik
Copy link

Alright. This morning I pulled the 24.1.1 that was available and still the permission denied issue persisted in the object folder. So, I was wondering if the issue was resolved or not.

@ksuderman
Copy link
Contributor Author

Is that with Kraken? I will try to reproduce using that.

@ksuderman ksuderman reopened this Jul 5, 2024
@DuttaAnik
Copy link

Yes, it is with Kraken. I also tried with Diamond database builder and faced the same error of permission denied.

@DuttaAnik
Copy link

Hi @ksuderman could you reproduce and resolve the error? Please let me know.

@ksuderman
Copy link
Contributor Author

Yes I am able to reproduce, at least I think it is the same problem you are experiencing. To be sure though, it is the data_manager_build_kraken2_database tool that is the problem and not kraken2 itself?

I think this is a separate, but related, bug. I am trying to get a few more data points before reaching out to the backend team to find a solution.

However, is there a reason you are trying to build the Kraken2 database manually rather than using the ones available on CVMFS? I see you have refdata.enabled=false in your values.yaml, at least the values shared on the GalaxyHelp channel. It looks like the database you want to use is available as part of the default reference data included on CVMFS.

refdata:
  enabled: true
  type: cvmfs
cvmfs:
  deploy: true  # unless you are deploying CVMFS separately from Galaxy
Screenshot 2024-07-09 at 12 34 01 PM

@DuttaAnik
Copy link

Hi @ksuderman thanks for reproducing the error. Yes, the problem is with the kraken2 database builder tool. Kraken2 itself works fine (or would work fine if there is a database).
Regarding your second question, I need to build the database using the Prebuilt RefSeq indexes which are available and getting updated once or twice a year. Also, there is an option of building a custom database with reference genomes other than NCBI. I am not using that at the moment. I am just trying to build it from the available ones and getting the error. For the time being, I can try to change the value file and use your suggestion.

@DuttaAnik
Copy link

Hi @ksuderman, I was wondering if there is any update on this issue. Thanks.

@ksuderman
Copy link
Contributor Author

Unfortunately not at this time. The problem is in the way Galaxy runs the post job event handler, which runs in the Galaxy process (pod) and not by the tool. We are still trying to determine why that event handler does not seem to have the proper volumes mounted.

@DuttaAnik
Copy link

Hi @ksuderman, I was wondering if there is any update on this issue. Thanks.

@ksuderman
Copy link
Contributor Author

Sorry for the delayed response, I was on vacation the past few weeks. This is on the top of my to-do list.

@nuwang nuwang added the bug label Sep 10, 2024
@DuttaAnik
Copy link

Hi @ksuderman no problem. Please let me know when you have any updates. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants