This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
maven plugin deploys test catalog with or without a galasa.token #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
techcobweb
commented
Mar 8, 2024
techcobweb
commented
- empty to force a build to run
- galasa-token is optional. It gets used if it is supplied
Signed-off-by: Mike Cobbett <[email protected]>
|
Build successful |
|
Build successful |
techcobweb
changed the title
techcobweb
changed the title
KirbyKatcher
reviewed
Mar 8, 2024
| public boolean skipDeployTestCatalog; | ||
|
|
||
| // A protected variable so we can inject a mock factory if needed during unit testing. | ||
| protected AuthenticationServiceFactory authFactory = new AuthenticationServiceFactoryImpl(); | ||
|
|
||
| protected BootstrapLoader bootstrapLoader = new BootstrapLoaderImpl(); | ||
|
|
||
| public static final boolean DEFAULT_ASSUMPTION_AUTHENTICATION_ENABLED = false ; | ||
|
|
||
| public static final String BOOTSTRAP_PROPERTY_NAME_IS_AUTH_ENABLED = "framework.auth.isEnabled"; |
There was a problem hiding this comment.
this constant is no longer required
KirbyKatcher
reviewed
Mar 8, 2024
galasa-maven-plugin/src/main/java/dev/galasa/maven/plugin/DeployTestCatalog.java
Outdated
Show resolved
Hide resolved
KirbyKatcher
reviewed
Mar 8, 2024
galasa-maven-plugin/src/main/java/dev/galasa/maven/plugin/DeployTestCatalog.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mike Cobbett <[email protected]>
KirbyKatcher
reviewed
Mar 8, 2024
There was a problem hiding this comment.
I think the tests in here should test if when a token is not supplied it makes a connection without the authorization header and with it if the token is present
|
Build successful |
Signed-off-by: Mike Cobbett <[email protected]>
KirbyKatcher
approved these changes
Mar 8, 2024
|
Build successful |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.