Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Editable Notes #172

Open
dylanpieper opened this issue Jun 28, 2022 · 5 comments
Open

Feature Request: Editable Notes #172

dylanpieper opened this issue Jun 28, 2022 · 5 comments

Comments

@dylanpieper
Copy link

Our organization has a need for end-users to edit slide notes without having to interact with the files/markdown. I believe this would make a great extension to the editable feature.

@gadenbuie
Copy link
Owner

Can you talk a bit more about what this feature might look like?

@dylanpieper
Copy link
Author

dylanpieper commented Jun 28, 2022

The primary aspect of the feature would be for presenters to edit existing notes in presenter mode. For consistency with the current editable function, I was thinking of using a modified version that converts the text output into a text input and allows changes to be stored (ideally permanently, as a cookie or otherwise).

A secondary aspect of the feature would be to add notes to a slide that does not have notes using a button or some sort of shortcut. This function would insert the ??? md syntax with placeholder text into the slide and wrap it in the editable function. However, in my opinion, this function is a much lower priority. Just being able to edit current notes is enough because the slide creator can always put in placeholder notes, then the end-user can edit them using the primary edit function.

I hope this helps. I am happy to brainstorm further.

@dylanpieper
Copy link
Author

Following up to see if you have any thoughts on this request @gadenbuie.

@gadenbuie
Copy link
Owner

gadenbuie commented Jul 7, 2022

I think I see how this could work now and it falls into two tasks:

  1. use_editable() could gain an argument to make notes editable. We don't need to modify the slide source, all slides get a notes space even if it's not used. We'd automatically associate a unique key for each notes area, automatically making the notes follow the same persistence rules as .can-edit[] blocks with keys.
  2. When in presenter mode, remark shows a "paused" overlay when in edit mode. This keeps the slides from jumping while you're typing. We need to hide this overlay when editing.

@rmharp

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants