Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaks with webpack > 4 #36

Closed
basaran opened this issue Nov 26, 2020 · 2 comments
Closed

breaks with webpack > 4 #36

basaran opened this issue Nov 26, 2020 · 2 comments

Comments

@basaran
Copy link

basaran commented Nov 26, 2020

Hello, it appears gabiseabra/google-fonts-webpack-plugin breaks with webpack 4. Could you please update the README?

This seems to be the default root package for google-fonts-webpack-plugin so, there is probably quite a few people who try this first like me and go into a debugging cycle.

yarn run v1.22.4                                                                          
$ vue-cli-service serve                                                                    
INFO  Starting development server...
10% building 2/2 modules 0 active(node:29517) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead       

beyonk-adventures/google-fonts-webpack-plugin is compatible with webpack > 4.

webpack/webpack#6568

@Rycochet
Copy link

Duplicate of #24 from more than two years ago

@basaran
Copy link
Author

basaran commented Nov 28, 2020

My request was to include this in the README. So, when someone has an issue and visits the github page, they could be alarmed as to why. This is the package that gets installed by default when you to npm or yarn without the repo prefix. It will probably make somebody's life easier.

@basaran basaran closed this as completed Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants