-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't use mousedown events instead of click #233
Comments
Oh yeah, I second this. |
You'll have to bring it to @gabboman. I also suggested this in the dev Discord but Gabbo noted that it was faster and linked this video. Sharing this to provide some context. Gabbo feel free to clarify anything I've stated here, this is interpretation of what we discussed last week. |
I haven't fully watched the linked video but even just reading through the comments, it's a big accessibility issue using mousedown instead of click. It shouldn't be something used everywhere |
I'll also note after testing that pressing enter on an element with |
First thing, this is not expected behavior. The action should only be done once the left mouse button has been lifted
Second, it breaks a lot of behavior. You can't drag, right click, middle click, navigational links without it triggering. This makes things more frustrating if you try to do something like opening a page in a new tab.
The text was updated successfully, but these errors were encountered: