Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use mousedown events instead of click #233

Open
Freeplayg opened this issue Jan 3, 2025 · 4 comments
Open

don't use mousedown events instead of click #233

Freeplayg opened this issue Jan 3, 2025 · 4 comments

Comments

@Freeplayg
Copy link

First thing, this is not expected behavior. The action should only be done once the left mouse button has been lifted

Second, it breaks a lot of behavior. You can't drag, right click, middle click, navigational links without it triggering. This makes things more frustrating if you try to do something like opening a page in a new tab.

@samolukadjo
Copy link

Oh yeah, I second this.

@FireIsGood
Copy link
Contributor

You'll have to bring it to @gabboman. I also suggested this in the dev Discord but Gabbo noted that it was faster and linked this video. Sharing this to provide some context.

Gabbo feel free to clarify anything I've stated here, this is interpretation of what we discussed last week.

@Freeplayg
Copy link
Author

Freeplayg commented Jan 6, 2025

I haven't fully watched the linked video but even just reading through the comments, it's a big accessibility issue using mousedown instead of click.

It shouldn't be something used everywhere

@FireIsGood
Copy link
Contributor

I'll also note after testing that pressing enter on an element with tabIndex will trigger the (click) event but not the (mousedown) event. This is why I had to implement custom (keydown) event handling for the navigation in #244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants