-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to handle Allele normalization for Range Locations #237
Comments
All great points. After looking at this for 30 minutes and thinking about it on a Sunday night, I tend to fall on the following side of things...
I think these range endpoints are only needed for microarray calls (unless someone can educate me otherwise). I believe these microarray calls really only produce representations of deleted or duplicated regions (often times with ambiguous endpoints). I think we will be treating these as copy number variants (CopyNumberChange Variants) in a a way this will help reduce the confusion on what and where these type of variants belong. Again, I'm no expert in all the places where these type of ambiguous variant calls come from, but I would say that calling them alleles is not exactly aligned with our computational definition. As we have noted many times, any "deletion" could be considered as a molecular variant and thus an Allele, but it is also a copy number (system) loss. Let's discuss further, but that's my Sunday night feedback for what it's worth. |
@ahwagner is it possible that Please educate me on why this is a non-sensical idea. |
@larrybabb regarding #237 (comment), I think that indefinite range data structures (and the |
This issue was marked stale due to inactivity. |
@ahwagner Where do we stand on this? Are we fully supporting the notion of It seems like we may just presume that any hgvs expression that has a |
I will make a comment here not fully understanding all the details. But I do think it is relevant. For CNVs specifically, our current filtration/annotation process uses bedtools intersect. The CNV calls are coming from DRAGEN. The CNV databases we are using include ClinVar, ClinGen, Decipher, GeneDx, Manta, and gnomAD. The typical requirement is a 50% reciprocal overlap between the patient/subject calls and the database. In the future when we adopt VRS IDs for CNVs I think we will want to be able to do the equivalent of bedtools intersect using the VRS objects. It looks to me like both |
One major theme raised in #234 is the question of "how do we handle Allele normalization when the Allele Location is specified by Ranges"? To me, these have always seemed to be a shorthand for "I did a targeted region assay and want to craft general statements about copy number in those regions and the potential broader impact they have". I know we allow people to create Alleles with Range-based Locations anyway, but... why? The PR supports those cases and raises interesting questions, e.g. what do we do with definite range intervals?
The text was updated successfully, but these errors were encountered: