Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy fails to MMDVM-Pi v1.0 #226

Open
m0vse opened this issue Apr 24, 2020 · 3 comments
Open

Deploy fails to MMDVM-Pi v1.0 #226

m0vse opened this issue Apr 24, 2020 · 3 comments

Comments

@m0vse
Copy link
Contributor

m0vse commented Apr 24, 2020

Hi,

Since commit f28a228 deploy to my MMDVM-Pi fails when trying to upload the firmware.

It appears that this is caused by the -c parameter to stm32flash (resume the connection). If I remove -c then it uploads fine but i'm not sure if this will break uploads to other F7xx based boards so I haven't submitted a PR.

Previously (before the above commit) it called stm32ld first which I assume opened the connection but if this failed to upload (because the CPU is not supported by stm32ld) then stm32flash would still upload as there was an existing connection to the CPU open but by removing the call to stm32ld, there is no existing connection to the CPU. Removing -c forces it to start a new connection.

73 Phil

@m0vse
Copy link
Contributor Author

m0vse commented Apr 26, 2020

For the avoidance of doubt, this is only for builds relating to Cortex-M7 (stm32f72xx) based boards.

@g4klx
Copy link
Owner

g4klx commented Apr 26, 2020

Please submit a PR, we'll see what happens.

@juribeparada
Copy link
Collaborator

I think removing the "-c" is safe, actually the use of stm32ld was an ugly workaround that I did long time ago. I tested and works fine for deploy in F4XX and F7XX RPi boards. I will add those mods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants