New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emissive factor defaults mismatch in material/physical.go #311

Open

thacuber2a03 opened this issue Sep 8, 2024 · 0 comments

thacuber2a03 commented Sep 8, 2024

engine/material/physical.go

Lines 76 to 79 in a2e58ab

    
           // SetEmissiveFactor sets the emissive color of the material. 
        
           // Its default is {1, 1, 1}. 
        
           // Returns pointer to this updated material. 
        
           func (m *Physical) SetEmissiveFactor(c *math32.Color) *Physical {

engine/material/physical.go

Lines 40 to 43 in a2e58ab

    
           // Creates uniform and set default values 
        
           m.uni.Init("Material") 
        
           m.udata.baseColorFactor = math32.Color4{1, 1, 1, 1} 
        
           m.udata.emissiveFactor = math32.Color4{0, 0, 0, 1}

is the comment or the assignment wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment