Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some System properties seem to be ignored in final build prism.allowhidpi #443

Open
2 of 5 tasks
sproket opened this issue Nov 2, 2024 · 4 comments
Open
2 of 5 tasks
Labels
bug Something isn't working

Comments

@sproket
Copy link

sproket commented Nov 2, 2024

I'm submitting a…

  • bug report
  • feature request
  • other

Short description of the issue/suggestion:

Setting the property prism.allowhidpi is ignored in final build

Steps to reproduce the issue/enhancement:

  • In Windows set display scale to 125%
  • Clone this repo: https://github.com/sproket/demo2
  • Run Launcher in IDE (launcher turns scaling off - scaling is off)
  • mvn clean
  • mvn install

check the target directory and run "demo.exe"
Window will be scaled so the EXE is not seeing the System property

What is the expected behavior?

Window should not be scaled since we set System.setProperty("prism.allowhidpi", "false");

What is the current behavior?

Window scales.

Do you have outputs, screenshots, demos or samples which demonstrate the problem or enhancement?

What is the motivation / use case for changing the behavior?

It doesn't work.

Please tell us about your environment:

  • JavaPackager version:n1.7.6
  • OS version: Windows 11
  • JDK version: 22
  • Build tool:
    • Maven
    • Gradle
@sproket
Copy link
Author

sproket commented Nov 3, 2024

Additional: It works fine with Launch4j option. It might just be a documentation task.

@fvarrui
Copy link
Owner

fvarrui commented Nov 3, 2024

Hi @sproket!
Do you mean that if we set -Dprism.allowhidpi=false in ${exeName}.l4j.ini as explained here it works?

@sproket
Copy link
Author

sproket commented Nov 4, 2024

I didn't have to do that. All I changed was changing winrun4j to launch4j and it worked. :)

@fvarrui
Copy link
Owner

fvarrui commented Nov 4, 2024

I didn't have to do that. All I changed was changing winrun4j to launch4j and it worked. :)

Oh, sorry, I missed that you were using WinRun4J instead of Launch4J 😅

So, the problem is in WinRun4J ... VM arguments are not working as expected.

@fvarrui fvarrui added the bug Something isn't working label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants