Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In rare cases, next_random_seed() fails #271

Open
jemus42 opened this issue Oct 22, 2024 · 1 comment
Open

In rare cases, next_random_seed() fails #271

jemus42 opened this issue Oct 22, 2024 · 1 comment

Comments

@jemus42
Copy link

jemus42 commented Oct 22, 2024

..or at least I am reasonably certain it does, because I found that the implementation here
https://github.com/DavisVaughan/furrr/blob/aa124bc06d9fc3e18ea047cb90d270ebeb8d9698/R/seed.R#L66-L73

uses the same validity check stopifnot(!any(seed_next != seed)) used in future and future.apply, see issue here:
futureverse/future.apply#122

The short version is that the underlying representation of NA values leads to a rare bug where the next seed drawn is actually NA rather than an integer, and the comparison fails.

HenrikBengtsson added a commit to HenrikBengtsson/furrr that referenced this issue Oct 27, 2024
@HenrikBengtsson
Copy link
Contributor

Thanks. I've created PR #272 fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants