Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple zip codes in one locality #63

Closed
cassidylaidlaw opened this issue Dec 16, 2016 · 4 comments
Closed

Multiple zip codes in one locality #63

cassidylaidlaw opened this issue Dec 16, 2016 · 4 comments
Assignees

Comments

@cassidylaidlaw
Copy link

One locality can have a number of zip codes; for instance, New York City has all zip codes of the form 100xx–104xx, 11004–05, 111xx–114xx, and 116xx. Also, sometimes people add an extra four digits to the end of the zip code to indicate a more specific location. The current implementation ties zip codes to localities and doesn't allow one locality to have multiple zip codes.

@jplehmann
Copy link

jplehmann commented Feb 19, 2017

Seems related to an issue I created a while ago, although that was more of a lookup issue, and you're pointing out a design issue. #34 (comment)

A less related zipcode issue: Localities are assigned the wrong zip/postal code #56

@furious-luke
Copy link
Owner

PR #41 will ensure a unique locality will be generated for each combination of locality name and zip code.

@explody
Copy link

explody commented Oct 26, 2018

I'll actually take this a bit further and say that postal codes should not be tied to locality at all. Postal codes are national constructs that overlay with the boundaries of metro areas.

The side effect here is that a large city like Los Angeles has > 900 zip codes which means one would end up with potentially hundreds of "Los Angeles, California, USA" entries just for separate zip codes - but the zips are inside Los Angeles, not the other way around - one city, many postal codes.

It seems like postal code should really just be an attribute of 'Address'. Or am I missing something about the design approach?

@banagale banagale self-assigned this Apr 10, 2020
@banagale banagale added this to the Ticket and PR Triage 1 milestone Apr 10, 2020
@banagale
Copy link
Collaborator

While the original issue described by @cassidylaidlaw has been resolved in pull/41, @explody 's structural question is still valid.

I'm closing this issue as completed, however I have made a note about considering refactoring postal code out of locality in a future release here. Please see #98 for updates on django-address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants