You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Those, we get "/" instead of "/", which breaks further routing at all.
So we should either change default security.uri_filter filter to 'htmlspecialchars' or note by a warning that usage 'htmlentities' with 'ENT_HTML5' leads to unexpected behavior and totally breaks routing.
The text was updated successfully, but these errors were encountered:
The fact that a developer is using a framework doesn't mean the develop shouldn't know how PHP works, i.e. what the effect is of using the ENT_HTML5 flag, it isn't really related to Fuel perse.
I'd say add it as a note to the docs if absolutely needed.
Fuel Version: 1.8.2
https://fuelphp.com/docs/classes/security.html
If we configure as in "default" security.uri_filter = array('htmlentities') and use HTML5 for templates => configure security.htmlentities_flags as e.g. ENT_QUOTES | ENT_HTML5 (so use ENT_HTML5 for flags), due to
https://github.com/fuel/core/blob/1.9/develop/classes/security.php#L100
https://github.com/fuel/core/blob/1.9/develop/classes/security.php#L148
silently instead of htmlentities we call \Security::htmlentities, which use flags from security.htmlentities_flags
https://github.com/fuel/core/blob/1.9/develop/classes/security.php#L211
that leads complex uri path e.g. 'complex/path/for/controller' to (phpsandbox example):
http://sandbox.onlinephpfunctions.com/code/ab79a3fd6dc30023a02ae2749331b1929c9ad776
Those, we get "/" instead of "/", which breaks further routing at all.
So we should either change default security.uri_filter filter to 'htmlspecialchars' or note by a warning that usage 'htmlentities' with 'ENT_HTML5' leads to unexpected behavior and totally breaks routing.
The text was updated successfully, but these errors were encountered: