diff --git a/TeamCode/src/main/kotlin/org/firstinspires/ftc/teamcode/constants/SlidesConstants.kt b/TeamCode/src/main/kotlin/org/firstinspires/ftc/teamcode/constants/SlidesConstants.kt index 18cf039..fc108f0 100644 --- a/TeamCode/src/main/kotlin/org/firstinspires/ftc/teamcode/constants/SlidesConstants.kt +++ b/TeamCode/src/main/kotlin/org/firstinspires/ftc/teamcode/constants/SlidesConstants.kt @@ -1,8 +1,8 @@ package org.firstinspires.ftc.teamcode.constants enum class SlidesConstants(val value: Double) { - kP(0.02), + kP(0.014), kI(0.0), - kD(0.00045), - kG(0.1) + kD(0.0), + kG(0.2) } \ No newline at end of file diff --git a/TeamCode/src/main/kotlin/org/firstinspires/ftc/teamcode/opModes/tuning/slides/SlidesPIDTuner.kt b/TeamCode/src/main/kotlin/org/firstinspires/ftc/teamcode/opModes/tuning/slides/SlidesPIDTuner.kt index 00808a2..4362548 100644 --- a/TeamCode/src/main/kotlin/org/firstinspires/ftc/teamcode/opModes/tuning/slides/SlidesPIDTuner.kt +++ b/TeamCode/src/main/kotlin/org/firstinspires/ftc/teamcode/opModes/tuning/slides/SlidesPIDTuner.kt @@ -50,7 +50,6 @@ class SlidesPIDTuner : CommandOpMode() { companion object { @JvmField - // NOTE THAT THIS VALUE SHOULD BE DEGREES var target = 0.0 } } \ No newline at end of file diff --git a/TeamCode/src/main/kotlin/org/firstinspires/ftc/teamcode/subsystems/slides/ElevatorSubsystem.kt b/TeamCode/src/main/kotlin/org/firstinspires/ftc/teamcode/subsystems/slides/ElevatorSubsystem.kt index 6aeee62..9ca765a 100644 --- a/TeamCode/src/main/kotlin/org/firstinspires/ftc/teamcode/subsystems/slides/ElevatorSubsystem.kt +++ b/TeamCode/src/main/kotlin/org/firstinspires/ftc/teamcode/subsystems/slides/ElevatorSubsystem.kt @@ -49,6 +49,7 @@ class ElevatorSubsystem( } override fun periodic() { + controller.setPID(kP, kI, kD) val output = controller.calculate(slidePos) if (enabled) @@ -69,7 +70,7 @@ class ElevatorSubsystem( companion object { @JvmField - var kP = 0.0 + var kP = 0.014 @JvmField var kI = 0.0 @@ -78,6 +79,6 @@ class ElevatorSubsystem( var kD = 0.0 @JvmField - var kG = 0.1 + var kG = 0.2 } } \ No newline at end of file