ResolveHooker class

[jbfp]

I'm trying to get an understanding of the codebase, and I've come across the ResolveHooker class. There's a comment saying it's an ugly hack that should be removed, and I tried commenting it out at https://github.com/fsprojects/fsharp-dnx/blob/master/src/FSharp.Dnx/FSharpCompiler.cs#L66 and it didn't seem to make a difference. Is it still required, do you think, or should it be removed? :)

[Alxandr]

Problem is, it's was only ever needed in certain cases. And I don't
remember which ones :P. As far as I know, it's still needed, but let me
look into it and get back to you.

On Sun, Oct 25, 2015, 16:34 Jakob Pedersen [email protected] wrote:

I'm trying to get an understanding of the codebase, and I've come across
the ResolveHooker class. There's a comment saying it's an ugly hack that
should be removed, and I tried commenting it out at
https://github.com/fsprojects/fsharp-dnx/blob/master/src/FSharp.Dnx/FSharpCompiler.cs#L66
and it didn't seem to make a difference. Is it still required, do you
think, or should it be removed? :)

—
Reply to this email directly or view it on GitHub
#16.

Alxandr

[jbfp]

Yeah I figured it was needed for some exotic edge case, but I always jump at a chance patch some "hacks" ;)

[Alxandr]

Yeah. Problem is, FSharp.Core is not a dependency of this project, but it's
always in the dependency chain somewhere. So yeah.

On Sun, Oct 25, 2015, 18:11 Jakob Pedersen [email protected] wrote:

Yeah I figured it was needed for some exotic edge case, but I always jump
at a chance patch some "hacks" ;)

—
Reply to this email directly or view it on GitHub
#16 (comment)
.

Alxandr

[jbfp]

But wouldn't it get pulled in when FSharp.Dnx is referenced, since it references FSharp.Core?

[Alxandr]

Hmm. You might be right. I think maybe this was needed because FSharp.Core used to be referenced as a build-time-only reference...