Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base of Unit Space Incorrectly Constructed #3

Open
davidkowalk opened this issue Sep 14, 2022 · 0 comments
Open

Base of Unit Space Incorrectly Constructed #3

davidkowalk opened this issue Sep 14, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@davidkowalk
Copy link
Contributor

If less than 7 variables are provided the program has to guess the remaining to construct a linearily independant basis. Instead the script currently pads the identity matrix. See src/interpreter.py at line 18 to 23.

Instead we need to systematically find linearly independent vectors.

Example for triggering the bug:

Input

Variable 1: p = 100000kg m^-1 s^-2  
Variable 2: V = 0.25 m^3
Variable 3: n = 130 mol
Variable 4: R = 8.3145 kg m^2 s^-2 mol^-1 K^-1

Units for target: K

Expected:

p^1 V^1 n^-1 R^-1

Got:

Matrix is not invertible. The provided Vectors may not be linearily independent.
@davidkowalk davidkowalk added the bug Something isn't working label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant