Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis.conf.erb template is tighly coupled to Redis 2.x and breaks with 3.x Redis deployments #60

Open
grantholly opened this issue May 23, 2017 · 2 comments

Comments

@grantholly
Copy link

grantholly commented May 23, 2017

After upgrading to Redis 3.2, puppet runs are now deleting the entire contents of Redis.conf. The heart of the issue if the redis.conf.erb template does not contain a block for Redis 3.x versions.

Here is the relevant bit of code in init.pp:
https://github.com/fsalum/puppet-redis/blob/master/manifests/init.pp#L118

And here in redis_version.rb:
https://github.com/fsalum/puppet-redis/blob/master/lib/facter/redis_version.rb#L18

When you go through the case statement in redis_version.rb, and you get the default of nil because 3.x versions have no matching case, and the value of $::redis_version of nil causes the problem with your redis.conf getting nuked.

@emerham
Copy link

emerham commented Jan 26, 2018

I am also plagued by this issue as well, but with Redis version 4, @grantholly did you fix it manually in the two files or did you move to another package?

@grantholly
Copy link
Author

I ended up not using this module

msrba pushed a commit to gwdg/puppet-redis that referenced this issue Dec 11, 2019
`bind` now takes an array (of IP addresses).
To bind to all interfaces, use `bind => []`.

Due to the new parameter validation, if you were previously using a
single string to specify multiple IP addresses, you will need to change
this to an array.

Fixes #257
Fixes fsalum#60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants