Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monas does not install optional dependencies for a local package #11

Open
AGiantSquid opened this issue Aug 4, 2023 · 0 comments
Open

Comments

@AGiantSquid
Copy link
Contributor

AGiantSquid commented Aug 4, 2023

If I run monas install --include pkgname, that command will not install the optional dependencies. If that project needs pytest, for example, I will not be able to run tests in that project until I navigate to the project, and run pip install .[test]

Describe the solution you'd like
The existing workflow isn't terrible, but there might be something better.

When you run monas with the --include flag, it is using a fnmatch to match the pattern.
I wonder if we could use a different flag to target a package in the more traditional way, like

monas install --local_pkg pkgname[test]

That command could check against the package name rather than the directory. If it matches a local package exactly (or on a normalized name), then it would install the local dependencies with -e, and then install the specified package with [test] brackets at the end (or whatever option was specified).

Another option would be to add a flag for optional dependencies to install

monas install --include pkgname --optional_dependencies test

and that would similarly add [test] to the install command for the packges that match the --include pattern

Open to thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant