fix: compilation on nightly #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it needs a little work. Please fix CI and then I will land. |
|
Ah I see, the cfg for those imports wasn't correct, they're needed in the no_std case (when none of the features are enabled, not just module-names) Should be good now I think, sorry about that |
|
I think you missed one.... |
|
oops, fixed |
|
Hey @s1341 gentle reminder in case you're busy/forgot about this pr :) |
|
Thanks for your contribution! |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not compile on nightly (
1.79.0-nightly (805813650 2024-03-31)to be exact) due to the#![deny(warnings)]attribute and redundant imports becoming a warning. Thanks!