Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing hover states on buttons : fill , stroke , background #351

Open
adambelis opened this issue Nov 30, 2024 · 10 comments
Open

Missing hover states on buttons : fill , stroke , background #351

adambelis opened this issue Nov 30, 2024 · 10 comments
Labels
Milestone

Comments

@adambelis
Copy link

  1. open fricion
  2. hover over this buttons
    image

there is no hover effect user does not have feebcakt that this are clickable buttons
bonus points if the label and icon were included as a clickable button
hover state
image

clicked state
image

@adambelis adambelis changed the title missing hower states on fill ,strone and bg buttons Missing hover states on buttons : fill , stroke , background Nov 30, 2024
@rodlie
Copy link
Member

rodlie commented Nov 30, 2024

Sure, I also assume we need something to indicate (tooltip?) that you can change the color while hovering with:

  • scroll = change hue
  • scroll + shift = change value
  • scroll + ctrl = change saturation
  • click = open fill/stroke widget

@rodlie rodlie added the ux label Nov 30, 2024
@rodlie rodlie added this to the 1.0.0 milestone Nov 30, 2024
@adambelis
Copy link
Author

Oh yes that's not very discoverable. Maybe as a tooltip or infobar. On hover

rodlie added a commit that referenced this issue Nov 30, 2024
Add better tooltip.

Ref: #351
@pgilfernandez
Copy link

May I have a look at this one?

@rodlie
Copy link
Member

rodlie commented Jan 1, 2025

May I have a look at this one?

I don't feel like refactoring the toolbutton right now ;)

Feel free, but from my POV there are more important things to fix before release. IMHO this issue should be moved to 1.1.

@pgilfernandez
Copy link

I've been looking at this for 2 hours and I'm unable to style it... as you say it would need to refactor the whole toolbutton to allow changing it's style... so, I give up

@rodlie
Copy link
Member

rodlie commented Jan 1, 2025

You can't style it, I use custom painting. I know what the problem is, but I didn't design it with hover state in mind. So some work is needed.

@pgilfernandez
Copy link

pgilfernandez commented Jan 1, 2025

BTW, what other important things are pending to be fixed before release? I could have a look and help if the issues are not so difficult or inside my not big C++ knowledge...

@rodlie rodlie modified the milestones: 1.0.0, 1.1.0 Jan 1, 2025
@rodlie
Copy link
Member

rodlie commented Jan 1, 2025

@pgilfernandez
Copy link

yeah, I was looking at milestone 1.0.0.
I might be able to fix #300, if not I will focus on Docs as I sometimes said I was gonna do but ended up doing other stuff...

Thanks

@rodlie
Copy link
Member

rodlie commented Jan 1, 2025

My current plan:

Beta 3 (~Monday)

  • Update the SDKs
  • Merge open PRs tagged 1.0.0

RC 1

  • Check for regressions
  • Try to fix open issues tagged as bug for milestone 1.0.0
  • Write basic docs
  • Write full release notes for 1.0.0
  • Review open issues for 1.0.0, move what we can't fix to milestone 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants