Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some considerations #2

Open
andremacola opened this issue Apr 25, 2020 · 2 comments
Open

Some considerations #2

andremacola opened this issue Apr 25, 2020 · 2 comments

Comments

@andremacola
Copy link

This is a nice way to continue what Justin successfully created. I'll try to collaborate in my free time.

Without wasting time:

  • First of all: Let's keep it simple as is need to be and follow the Wordpress UI, without colorful and polluted interfaces.
  • Composer is great. I use it in my WP projects but what about release to the community in Wordpress Plugin Repository
  • Get all the translations Members had, like portuguese and others. Maybe we can use Transifex? I have the pt-BR file here. How we can get the others?
  • I see that you removed the REST API option. Is there any motive? I think we can explore some REST API functionalities
  • I don't known if Gutenberg has some user roles no manage blocks. Actually I never explored how Gutenberg works in this area of permissions. Maybe we can add roles for specific type of blocks?
  • Let's try to modern the javascript in the backend bump the jQuery. I know is in the core of the WP but I'm thinking in the future.
  • I think we can name Permission Manager (PM) is great name. Without the "WP" and follow a more professional naming convention like "Admin Columns", "Advanced Custom Fields", "Yoast" etc..

We can start with the simple things like the translations or release the plugin to get users feedbacks

@thomasfw
Copy link
Member

@andremacola thanks for your input and apologies for the delayed response.

Composer is great. I use it in my WP projects but what about release to the community in Wordpress Plugin Repository

We'll be publishing to the WP plugin repo after we've done some refactoring, so for now this is scheduled for the next major release.

Get all the translations Members had, like portuguese and others. Maybe we can use Transifex? I have the pt-BR file here. How we can get the others?

I didn't see any translation files in the original plugin source, but agree it would be good to get these added especially if they're already available.

I see that you removed the REST API option. Is there any motive? I think we can explore some REST API functionalities

We've removed all features that aren't directly related to role/capability management. This is so that we can reduce the maintenance burden, and because there are plenty of other plugins or simple code snippets that handle these responsibilities well.

I don't known if Gutenberg has some user roles no manage blocks. Actually I never explored how Gutenberg works in this area of permissions. Maybe we can add roles for specific type of blocks?

It's unlikely that we'll be adding significant functionality to the plugin, especially if it's not related to role/cap management.

Let's try to modern the javascript in the backend bump the jQuery. I know is in the core of the WP but I'm thinking in the future.

This would definitely be nice. It looks like some work was being done on modernising the UI and JS (here) so this is something we'll look into after v4.

I think we can name Permission Manager (PM) is great name. Without the "WP" and follow a more professional naming convention like "Admin Columns", "Advanced Custom Fields", "Yoast" etc..

We use the wp- prefix as an internal naming convention for any WordPress projects/packages so that they're easily distinguishable. I will update the title throughout the plugin, but the package name and plugin slug will most likely remain unchanged for this reason.

@andremacola
Copy link
Author

@thomasfw Agreed.

About the translations, I can send a PR but I did not find the DEV branch, can I send PRs to MASTER?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants