ethereum: added e2e tests #2218
Conversation
aramikm
requested review from
shannonwells,
mattheworris,
saraswatpuneet and
JoeCap08055
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable no-restricted-syntax */ | |||
There was a problem hiding this comment.
Only ignoring the custom rule in here
aramikm
changed the title
| @@ -51,6 +51,19 @@ export default tseslint.config( | |||
| }, | |||
| ], | |||
| 'allow-namespace': 'off', | |||
| 'no-restricted-syntax': [ | |||
There was a problem hiding this comment.
adding new rules so going forward we have to use correct functions
| const schema = { | ||
| type: 'record', | ||
| name: 'Post', | ||
| fields: [ | ||
| { name: 'title', type: { name: 'Title', type: 'string' } }, | ||
| { name: 'content', type: { name: 'Content', type: 'string' } }, | ||
| { name: 'fromId', type: { name: 'DSNPId', type: 'fixed', size: 8 } }, | ||
| { name: 'objectId', type: 'DSNPId' }, | ||
| ], | ||
| }; | ||
|
|
||
| schemaId = await ExtrinsicHelper.getOrCreateSchemaV3( | ||
| keys, | ||
| schema, | ||
| 'AvroBinary', | ||
| 'OnChain', | ||
| [], | ||
| 'test.grantDelegation' | ||
| ); | ||
|
|
||
| schemaId2 = await ExtrinsicHelper.getOrCreateSchemaV3( | ||
| keys, | ||
| schema, | ||
| 'AvroBinary', | ||
| 'OnChain', | ||
| [], | ||
| 'test.grantDelegationSecond' | ||
| ); | ||
| }); |
There was a problem hiding this comment.
nit: probably don't need to create schemas any more, unless actually testing the schemas pallet, as mainnet schemas should be available on all chains now
There was a problem hiding this comment.
yeah this is getting the schemaId if it already exists but I agree that we can refactor all these schema creation everywhere and simplify it but looks like a wider effort outside of the scope of this ticket. Will create an issue for it
|
@JoeCap08055 There are some minor other differences between ethereum ones and other ones besides the keys used. One of the benefits of having them in separate files is that I can just change the test selector to |
If there's a good reason, then I'm fine with it. |
There was a problem hiding this comment.
Couple of non-blocking comments from me, if you can add those extra checks that @JoeCap08055 suggested I think that would be a good idea.
Goal
The goal of this PR is
Closes #2203
Discussion
Checklist