adding ethereum h160 style account support #2206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
4 tasks
|
Closed by a new PR #2216 |
aramikm
added a commit
that referenced
this pull request
Nov 15, 2024
# Goal The goal of this PR is to allow sending transactions using ethereum signatures and ethereum addresses Closes #2206 # Changes - Replaced `MultiSignature` with `UnifiedSignature` in the runtime which supports ethereum signatures for ecdsa - Replaced `AccountIdLookup` with `EthereumCompatibleAccountIdLookup` in runtime which support 20 bytes accounts in MultiAddress - Showing runtime logs for `start-frequency-instant` mode (this would be helpful in debugging) # Warning - For e2e test we should use `getUnifiedAddress(keyPair)` function instead of `keypair.address` directly. Thisb would ensure we are using correct ethereum address for ethereum keys. # Checklist - [x] Updated js/api-augment for Custom RPC APIs? - [x] Unit Tests added? - [x] e2e Tests added? - [x] Spec version incremented?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is show that it will be possible to support H160 accounts (with some changes) on frequency
Closes #2192
Discussion
Checklist