Rename "get_by_schema_id" to "get_[thing]_by_schema_id"

[shannonwells]

Feature Description

Details

It's confusing in the code, and has already been the source of a bug (see #2164) to have >1 function named get_by_schema_id which return two different things, and a function named get_schema_by_id. The latter name makes sense because you are getting a thing (a schema) using another thing (its id) and that's plain by the name.

So, for the other two, let's rename to get_message_by_schema_id and get_schema_by_schema_id, at least in the Rust code. For the JS API it's a little tougher but one could add new functions and deprecate the old ones for now.

Possible Related Issues

#2054

Searched for Related Issues

• I have done a search for related issues and either found none, or noted them