-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendar #150
Conversation
a002ebf
to
f1981bf
Compare
I will change the event box color, so that it fulfills the accessibility criteria. Do you have other feedback on look/feel and features? |
Also I would squash the commits before merging. |
the preview URL is just showing a 404. |
Ah sorry, forgot about that, i fixed the link |
The line length is to high if you click an event. Should be reduced to the same width as the normal layout. |
I used rrules to define recurring events, because this is the standard in ical. I would keep it that way. Then I used the library rrules to transform those rules into natural language. Works perfectly 😄 ... but only for englisch 😞. The library has issues with translations. There is no good solution for that right now. I tried some of the solutions mentioned in the issue, but without a result that is acceptable "jedes Monat auf dem NaN Mittwoch" 😆. I introduced an additional variable to create the text manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me now. squash this into a single commit and then feel free to merge.
My solution is that we generate ical feeds with hugo that are consumed and displayed by a js calendar. So we have a nice overview on the website and people can subscribe to the feed iif they want. New events are added like other content with a simple md file.
Separate feeds forcommunity
,installation
andexternal
eventsThis resolves #133