You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fix in PR #8 allowed the Alembic migrations to run even if it could not find the config file that ordinarily would let Alembic set up logging. However, this means that the alembic upgrade process is leaving no log entries in production, which is not ideal.
We should fix this one of these 3 ways:
Even if Alembic can't find a config file with logging directives, it sets up logging with some reasonable defaults that match what's in the current alembic.ini file.
Fix the way this gets invoked from freezing-web so that it knows where its config file should live
Some other way to get logging going that I'm too ignorant to know about since I'm a SQLAlchemy newbie 😊
The text was updated successfully, but these errors were encountered:
I'm actually a bit unfamiliar with what alembic logs normally (when not using programmatic mode). I'm also a little surprised that we're not seeing anything, since we're constructing the Config object manually and this happens after we've already initialized logging. Maybe Alembic is logging at debug and they're just being suppressed?
See the section -- and particularly the warning -- under Config class for notes on programmatic instantiation of the Config objects. The docs aren't entirely clear to me:
Warning - When using programmatic configuration, make sure the env.py file in use is compatible
with the target configuration; including that the call to Python logging.fileConfig() is omitted if the
programmatic configuration doesn’t actually include logging directives.
There is logging indicating that the database is being upgraded. It may be that having individual logs about the specific revisions being migrated are not necessary / juice is not worth the squeeze ?
The fix in PR #8 allowed the Alembic migrations to run even if it could not find the config file that ordinarily would let Alembic set up logging. However, this means that the alembic upgrade process is leaving no log entries in production, which is not ideal.
We should fix this one of these 3 ways:
freezing-web
so that it knows where its config file should liveThe text was updated successfully, but these errors were encountered: