Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support trickle-ICE #2

Open
richardscreene opened this issue Sep 21, 2020 · 3 comments
Open

Support trickle-ICE #2

richardscreene opened this issue Sep 21, 2020 · 3 comments
Labels
fixed Fixed - ready for release

Comments

@richardscreene
Copy link
Collaborator

richardscreene commented Sep 21, 2020 •
edited
Loading

Currently mod_janus ignores trickle messages from Janus, hence trickle-ICE connections will not succeed. Janus must be configured so that trickle-ICE is not used.

We should really handle the trickle messages.

Interim solution is to set the full-trickle command line flag to Janus.
richardscreene added a commit that referenced this issue Oct 8, 2020
@richardscreene
#2 Implement ICE trickle
278add5
@richardscreene richardscreene added the fixed Fixed - ready for release label Oct 9, 2020
@richardscreene
Copy link
Collaborator Author

Fixed waiting for merge into master when I get the time.

@cmcom-gb
Copy link

cmcom-gb commented Mar 9, 2021

Hi @richardscreene, any idea when this will be merged with master?
We're currently using the below settings in janus.jcfg which seems to work fine.

full_trickle = false
ice_lite = true

@richardscreene
Copy link
Collaborator Author

Should be done now (tagged v1.1.0)
Let me know if you have any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Fixed - ready for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richardscreene @cmcom-gb