Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freenet local ; command is absouletly broken #970

Closed
gogo2464 opened this issue Jan 24, 2024 · 25 comments
Closed

freenet local ; command is absouletly broken #970

gogo2464 opened this issue Jan 24, 2024 · 25 comments
Assignees
Labels
C-bug Category: This is a bug. regression

Comments

@gogo2464
Copy link
Contributor

I can push the contract with fdev publish but when I want to reach I have:

failed to get contract XXX, reason: Missing contract and/or parameters

I also got:

storing private key file: `identity-manager-key.private.pem`
storing private key file: `identity-manager-key.public.pem`
storing parameters file: `identity-manager-params`
cd /PATH/freenet-core/modules/antiflood-tokens/contracts/token-allocation-record
fdev build
Compiling contract with rust
error: failed to parse lock file at: /PATH/freenet-core/modules/antiflood-tokens/Cargo.lock

Caused by:
  package `freenet-stdlib` is specified twice in the lockfile
Error: exit with status: exit status: 101
make: *** [Makefile:79: build-token-allocation-contract] Error 1

not sure if linked. Might be an issue on my side. I had already published and visited 2 sites I created before I recompiled freenet and got this issue.

@sanity
Copy link
Collaborator

sanity commented Jan 24, 2024

So any contract you push into the network isn't retrievable? And this is a regression of something that worked before?

@sanity sanity added C-bug Category: This is a bug. regression labels Jan 24, 2024
@sanity
Copy link
Collaborator

sanity commented Jan 24, 2024

Also, this is the main branch?

@gogo2464
Copy link
Contributor Author

So any contract you push into the network isn't retrievable? And this is a regression of something that worked before?

yes it used to work. it does not work anymore

@gogo2464
Copy link
Contributor Author

yes I tested on the main branch: the contract are not reached anymore

@gogo2464
Copy link
Contributor Author

I did:

git clone https://github.com/freenet/freenet-core/ && 
cd freenet-core && 
git submodule update --init --recursive && 
export CARGO_TARGET_DIR="$(pwd)/target" &&
cargo install --path crates/core --force &&
cargo install --path crates/fdev --force &&
cd apps/freenet-microblogging &&
make build && make run-node

@gogo2464
Copy link
Contributor Author

And yes NOT any contract is reachable anymore.

@gogo2464
Copy link
Contributor Author

gogo2464 commented Jan 24, 2024

also in order to ensure that you tested right you have to do:

cargo clean
rm -Rf "${CARGO_TARGET_DIR}"
rm -rf ~/.local/share/freenet

@gogo2464
Copy link
Contributor Author

does the microblogging contract and any contract require antiflood token? Might be the root cause.

Caused by:
package freenet-stdlib is specified twice in the lockfile

@gogo2464
Copy link
Contributor Author

even my reset to 2c5dfd3 commit does not bring back the web contract fetching

@iduartgomez
Copy link
Collaborator

Aren't you sure you are not on the wrong stdlib branch?

Do git submodule update

@gogo2464
Copy link
Contributor Author

I have done git submodule update --init --recursive seems same.

@gogo2464
Copy link
Contributor Author

$ cd stdlib/
$ git log -n 3
commit 7729fe328f360067a8ac21fa5809ac0bf748198f (HEAD)
Author: Ignacio Duart <[email protected]>
Date:   Fri Dec 15 15:36:21 2023 +0100

    New error kind

@gogo2464
Copy link
Contributor Author

@sanity did you successfully view the contract after my commands please?

@sanity
Copy link
Collaborator

sanity commented Jan 26, 2024

@gogo2464: Can you try this in the modules/antiflood-tokens/contracts/token-allocation-record directory:

$ cargo update

That may resolve the problem with the Cargo.lock file.

@gogo2464
Copy link
Contributor Author

it does not. it requires to delet Cargo.lock

@gogo2464
Copy link
Contributor Author

this commit might be responsible of the issue:

6ef6048

the older work. I am looking for more recent

@gogo2464
Copy link
Contributor Author

gogo2464 commented Jan 27, 2024

I am now absolutely 100% sure that the commit 6ef6048 is responsible of the breaking change!!

the commit just older than this one is running contrary to it

@gogo2464
Copy link
Contributor Author

@iduartgomez could you be assigned to this issue please?

@netsirius
Copy link
Collaborator

@gogo2464 Apparently, the publish never manages to save the contract due to an issue in the perform_contract_put method. By fixing this issue, I have been able to successfully launch the application.
image
Now I am verifying that there are no more issues I will upload a fix.

@gogo2464
Copy link
Contributor Author

THANKS @netsirius !!!

Could you link your pr please? I would like to use it immediately. :)

@gogo2464
Copy link
Contributor Author

https://github.com/freenet/freenet-core/actions/runs/7688432191/job/20949648629?pr=974#step:4:1994

It seems @netsirius , you have to fix it in order to let me finish the testing. #975

@netsirius
Copy link
Collaborator

@gogo2464 The fix has just been merged. Can you confirm that the issue has been resolved to close it?

@netsirius netsirius self-assigned this Jan 30, 2024
@gogo2464
Copy link
Contributor Author

@netsirius sure I am going to. I made a PR to easily build on Linux #974 sadly web-sys has also been broken itself as freenet dependency and the chances it does not impact the new freenet is poor.

@gogo2464
Copy link
Contributor Author

seems to work with the microblogging contract for me. let me try personnal apps!

@gogo2464
Copy link
Contributor Author

gogo2464 commented Apr 1, 2024

I did not test on email app. may be ok. let's close the issue

@sanity sanity closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression
Projects
None yet
Development

No branches or pull requests

4 participants