Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): Tweaks the src attribute to display icons properly #354

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

ERosendo
Copy link
Contributor

This PR implements a fix for broken icons encountered in Safari 17.2 and Firefox 120.0.1.

@ERosendo ERosendo added the no changelog Override Check Changelog Action. label Dec 18, 2023
@ERosendo ERosendo marked this pull request as draft December 18, 2023 20:02
@ERosendo ERosendo force-pushed the fix-broken-icons-in-firefox-and-safari branch 2 times, most recently from 4884276 to eb65cb9 Compare December 18, 2023 20:06
@ERosendo ERosendo force-pushed the fix-broken-icons-in-firefox-and-safari branch from eb65cb9 to 5f5a4c2 Compare December 18, 2023 20:10
@ERosendo ERosendo marked this pull request as ready for review December 18, 2023 20:10
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mlissner mlissner merged commit 6475a5e into main Dec 18, 2023
8 checks passed
@mlissner mlissner deleted the fix-broken-icons-in-firefox-and-safari branch December 18, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Override Check Changelog Action.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants