Fix setDefaultOptions in updateToolbarButton

freelawproject · Oct 3, 2024 · f83c0c5 · f83c0c5
1 parent b714080
commit f83c0c5
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/utils/toolbar_button.js b/src/utils/toolbar_button.js
@@ -31,6 +31,13 @@ export function updateToolbarButton(tab) {
   };
 
   chrome.storage.local.get('options', function (items) {
+    if (!Object.keys(items).length) {
+      // Firefox 56 bug. The default settings didn't get created properly when
+      // upgrading from the legacy extension. This can be removed when everybody
+      // is safely beyond 56 (and the ESR)
+      setDefaultOptions({});
+    }
+
     if (
       'dismiss_news_badge' in items['options'] &&
       items['options']['dismiss_news_badge']
@@ -52,12 +59,6 @@ export function updateToolbarButton(tab) {
       });
       return;
     }
-    if (!Object.keys(items).length) {
-      // Firefox 56 bug. The default settings didn't get created properly when
-      // upgrading from the legacy extension. This can be removed when everybody
-      // is safely beyond 56 (and the ESR)
-      setDefaultOptions({});
-    }
 
     if (items && items['options'] && !items['options']['recap_enabled']) {
       setTitleIcon('RECAP is temporarily disabled', {