Switch systemd units to use Type=exec instead of Type=oneshot #7350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`oneshot` is designed to be used with RemainAfterExit, but we don't need that nor use it. After reviewing <https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html>, `exec` appears to be the correct type since we want the service to be running once the binary has started, not once it's finished. Practically this shouldn't make a big difference except that `systemctl start <name>` won't wait for the entire command to complete. Fixes #7349.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
oneshotis designed to be used with RemainAfterExit, but we don't need that nor use it. After reviewinghttps://www.freedesktop.org/software/systemd/man/latest/systemd.service.html,
execappears to be the correct type since we want the service to be running once the binary has started, not once it's finished.Practically this shouldn't make a big difference except that
systemctl start <name>won't wait for the entire command to complete.Fixes #7349.
Testing
How should the reviewer test this PR?
Deployment
Any special considerations for deployment? n/a
Checklist