Display a banner in the JI regarding the noble migration #7348
+61
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This actively dissuades from using HTTPS URLs, favoring protocol-relative ones. Even ignoring HTTPS-only URLs as a best practice, given most onion services are hosted as HTTP sites, they'd become HTTP links instead of HTTPS. So let's just suppress this rule and link to the correct protocol.
legoktm
force-pushed
the
noble-ji-warnings
branch
from
34eb65e
to
81421e3
Compare
This is largely copied from the same functionality that was implemented during the focal migration (ecfecea). Co-authored-by: soleilera <[email protected]>
legoktm
force-pushed
the
noble-ji-warnings
branch
from
81421e3
to
0b287e7
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Work in progress
Description of Changes
This is largely copied from the same functionality that was implemented during the focal migration (ecfecea).
Refs #7322
Testing
How should the reviewer test this PR?
TK
Deployment
Any special considerations for deployment? n/a
Checklist
make lint) and tests (make test) pass in the development container