Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Selenium 4, add ignores for alerts 63066, 63227 #7100

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Update to Selenium 4, add ignores for alerts 63066, 63227 #7100

merged 4 commits into from
Jan 8, 2024

Conversation

zenmonkeykstop
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop commented Jan 5, 2024 •
edited by legoktm
Loading

Status

Ready for review

Description of Changes

  • updates Selenium to 4.16.0, tbselenium to 0.8.1
  • updates functional tests to work with Selenium 4 (mostly just updating find_element*() calls and webdriver invocations)
  • adds ignores for ansible and paramiko safety alerts

Testing

  • CI is passing
  • functional tests pass locally - try securedrop/bin/dev-shell bin/run-tests -v tests/functional if you don't want to run the entire suite
  • CI execution time not adversely affected by Selenium update.

@zenmonkeykstop zenmonkeykstop requested a review from a team as a code owner January 5, 2024 04:22
@zenmonkeykstop zenmonkeykstop marked this pull request as draft January 5, 2024 05:12
@zenmonkeykstop zenmonkeykstop marked this pull request as ready for review January 5, 2024 19:36
@legoktm legoktm self-assigned this Jan 8, 2024
legoktm
legoktm approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was pretty slow for me locally, but tbh it's always been slow. CI times look normal so I think it's just a me issue.

@legoktm legoktm merged commit 343d60a into develop Jan 8, 2024
17 checks passed
@legoktm legoktm deleted the jan-sec-updates branch January 8, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legoktm legoktm legoktm approved these changes

Assignees

@legoktm legoktm

Labels
goals: sick CI small off-sprint PR
Projects
SecureDrop dev cycle
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zenmonkeykstop @legoktm