Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup regression regarding the redis password #7328

Open
legoktm opened this issue Nov 7, 2024 · 3 comments
Open

backup regression regarding the redis password #7328

legoktm opened this issue Nov 7, 2024 · 3 comments

Comments

@legoktm
Copy link
Member

legoktm commented Nov 7, 2024

Description

I haven't verified it yet, but there's probably a regression in the backup/restore prodecure now that we set a redis password. The password is set in config.py, which we backup, but we don't backup the redis.conf, so when it is restored, that same password won't be re-added to the redis config (a different one will be randomly generated).

We're also not backing up the new rq_config.py file.

@zenmonkeykstop
Copy link
Contributor

We could probably regenerate it, I don't think we need to persist any redis state between backups.

@legoktm legoktm added this to the SecureDrop 2.11.0 milestone Nov 7, 2024
@legoktm
Copy link
Member Author

legoktm commented Nov 7, 2024

Ack, that's probably better. Since we already run dpkg-reconfigure securedrop-app-code, I think we should delete the redis password out of config.py (if set), out of redis.conf (if set), and then delete rq_config.py (if it exists) and then let it be regenerated by the postinst script.

I'll think about edge cases a bit more but tentatively tagging with the 2.11.0 milestone.

@legoktm
Copy link
Member Author

legoktm commented Nov 12, 2024

I'm planning to tackle this after #7331 lands because that one moves the script around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to go
Development

No branches or pull requests

2 participants