Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenshots, and maybe translation tests, run only under en_US #7241

Closed
cfm opened this issue Oct 7, 2024 · 1 comment · Fixed by #7240
Closed

screenshots, and maybe translation tests, run only under en_US #7241

cfm opened this issue Oct 7, 2024 · 1 comment · Fixed by #7240
Labels
bug i18n Anything related to translation or internationalization of SecureDrop tests

Comments

@cfm
Copy link
Member

cfm commented Oct 7, 2024

Description

At least some of the translation test suite runs with only en_US available, so that's the language it uses in practice.

Steps to Reproduce

$ securedrop/bin/dev-shell bin/translation-test de_DE

Expected Behavior

Tests run and screenshots are generated in de_DE.

Actual Behavior

Tests run and screenshots (e.g.) are generated in en_US, with no other languages available for selection

Comments

Flagged by @legoktm in #7240 (review).

@cfm cfm added bug tests i18n Anything related to translation or internationalization of SecureDrop labels Oct 7, 2024
@cfm
Copy link
Member Author

cfm commented Oct 7, 2024

Fixtures were parameterized incorrectly at both ends of this end-to-end testing:

  • In 4db4bd7, the server fixture was missing SUPPORTED_LOCALES, so it provided only the default en_US.
  • In 7edff79, the client fixture was set up before the test was parameterized.

Both fixes are proposed as part of #7240.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug i18n Anything related to translation or internationalization of SecureDrop tests
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant