Replace salt updater in sd-sys-vms #1165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It just silently failed with error 46. I have now added |
|
Feedback on the chosen parameters is welcome. I made it verbose just so that progress failures are evident in the logs, but it could be too verbose. |
|
Hey @deeplow, thanks for preparing this, couple thoughts:
|
You're right. This is too verbose. I opted for this because I wanted somehow to be an indication of progress, but since this will be printed on a regular terminal (dev / prod machines) but also on a dumb terminal (CI), the line editting thing would end up consuming way more lines, if you see what I mean. This is the kind of "dynamic" progress reporting it has:
I guess the best approach is just to drop the progress all-together and have instead Example of first update on a minimal with --show-output
Not sure. It is used in other places in the code. Probably for another PR, I'd say.
Good call. I had that in the regular updater, but missed on this one. |
Replace salt updater with qubes-vm-update in sd-sys-vms. Suppress output since it is likely to be verbose due to this being the first update the template receives since it was built. Unlike the salt updater, in with qubes-vm-update if a target qube does not exist, the updater will fail. This is what caused #1165 to go undetected.
The incorrect variable was telling the system to update fedora-40 (which does not exist in default systems) instead of fedora-40-xfce. Fixes #1166
deeplow
force-pushed
the
deeplow-replace-salt-updater
branch
from
e41990a
to
15c3273
Compare
|
@rocodes I have added the The main thing we want here is to be alerted if it failed, which |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace salt updater with qubes-vm-update in sd-sys-vms
Status
Work in progress
Description of Changes
Fixes #1166.
Changes proposed in this pull request:
Testing
Run
make devand ensure when running sd-sys-vms step the qube started and fully updated.Deployment
Any special considerations for deployment? Consider both:
Checklist
If you have made changes to the provisioning logic
make test) pass indom0If you have added or removed files
MANIFEST.inandrpm-build/SPECS/securedrop-workstation-dom0-config.specIf documentation is required